Expose ProtoToolchainInfo to Starlark #13732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@katre PTAL |
katre
reviewed
Jul 23, 2021
| private final Object protoCommon; | ||
| private final StarlarkAspectApi protoRegistryAspect; | ||
| private final ProviderApi protoRegistryProvider; | ||
|
|
||
| public ProtoBootstrap( | ||
| ProtoInfoProviderApi protoInfoApiProvider, | ||
| ProtoToolchainInfoApi.Provider protoToolchainInfoApi, |
There was a problem hiding this comment.
ProtoInfo is passing the actual Api class, not the Api.Provider. Why the difference here?
There was a problem hiding this comment.
ProtoInfo also passes the provider, but they named it ProtoInfoApi.ProtoInfoProviderApi
There was a problem hiding this comment.
Ah, I see. Thanks for clarifying.
|
Okay, apparently our internal Java toolchain is stricter than what we have externally. Can you investigate and fix these warning/errors: |
|
cannot repro locally, but I added the missing type parameters. Let me know if there are more errors |
bazel-io
pushed a commit
that referenced
this pull request
Nov 15, 2021
*** Reason for rollback *** Starlarkification of proto_library is making progress faster than its toolchainization effort. As such adding JavaToolchainInfo directly to the Starlark implementation will be much easier than adding a native support for it (it's 2 lines of code vs. this PR). *** Original change description *** Expose ProtoToolchainInfo to Starlark Progress on https://docs.google.com/document/d/1go3UMwm2nM8JHhI3MZrtyoFEy3BYg5omGqQmOwcjmNE/edit Closes #13732. PiperOrigin-RevId: 410076628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on https://docs.google.com/document/d/1go3UMwm2nM8JHhI3MZrtyoFEy3BYg5omGqQmOwcjmNE/edit