junitrunner: Report suppressed and ignored tests as skipped. #13717

benjaminp · 2021-07-19T23:26:54Z

Fixes #6688
(after java tools release)

google-cla · 2021-07-19T23:26:59Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-07-19T23:27:47Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-07-19T23:34:38Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

comius · 2021-07-21T05:55:55Z

...ools/junitrunner/javatests/com/google/testing/junit/runner/model/AntXmlResultWriterTest.java

+    TestSuiteNode parent = createTestSuite();
+    TestCaseNode skipped = createTestCase(parent);
+    skipped.started(testInstant(Instant.ofEpochMilli(1)));
+    skipped.testSkipped(testInstant(Instant.ofEpochMilli(2)));
+    TestCaseNode suppressed = createTestCase(parent);
+    suppressed.testSuppressed(testInstant(Instant.ofEpochMilli(4)));
+    resultWriter.writeTestSuites(writer, root.getResult());
+    Document document = parseXml(stringWriter.toString());
+    NodeList caseElems = document.getElementsByTagName("testcase");
+    assertThat(caseElems.getLength()).isEqualTo(2);
+    for (int i = 0; i < 2; i++) {
+      Element caseElem = (Element) caseElems.item(i);
+      NodeList skippedElems = caseElem.getElementsByTagName("skipped");
+      System.out.println(stringWriter.toString());
+      assertThat(skippedElems.getLength()).isEqualTo(1);
+    }
+  }


Please break the test into three blocks: arrange (setting things up), act (running), assert (verifying results). Separate each block with an empty line.
Remove System.out.println.

Fixes bazelbuild#6688 (after java tools release)

or-shachar · 2021-07-25T13:18:09Z

YEY! :) ❤️

Yannic · 2022-06-24T20:53:45Z

@bazel-io flag

Yannic · 2022-06-24T20:55:57Z

Eh, wait. This should already be in Bazel 5.

ckolli5 · 2022-06-27T15:27:19Z

@bazel-io fork 5.3.0

ckolli5 · 2022-06-28T16:01:58Z

@Yannic Yes, this change is already present. Closing the forked issue. Thanks!

google-cla bot added the cla: no label Jul 19, 2021

benjaminp force-pushed the skip-test-reporting branch from e873a47 to 91e8a87 Compare July 19, 2021 23:27

benjaminp force-pushed the skip-test-reporting branch from 91e8a87 to 61158a5 Compare July 19, 2021 23:34

benjaminp force-pushed the skip-test-reporting branch from 61158a5 to ef8b27c Compare July 20, 2021 00:57

google-cla bot added cla: yes and removed cla: no labels Jul 20, 2021

meisterT requested a review from comius July 20, 2021 20:19

comius reviewed Jul 21, 2021

View reviewed changes

junitrunner: Report suppressed and ignored tests as skipped.

0609ee4

Fixes bazelbuild#6688 (after java tools release)

benjaminp force-pushed the skip-test-reporting branch from ef8b27c to 0609ee4 Compare July 21, 2021 05:57

comius approved these changes Jul 21, 2021

View reviewed changes

bazel-io closed this in 45092bb Jul 21, 2021

benjaminp deleted the skip-test-reporting branch July 21, 2021 14:25

bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jun 24, 2022

bazel-io mentioned this pull request Jun 27, 2022

[5.3.0] junitrunner: Report suppressed and ignored tests as skipped. #15749

Closed

bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jun 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

junitrunner: Report suppressed and ignored tests as skipped. #13717

junitrunner: Report suppressed and ignored tests as skipped. #13717

benjaminp commented Jul 19, 2021 •

edited

Loading

google-cla bot commented Jul 19, 2021

google-cla bot commented Jul 19, 2021

google-cla bot commented Jul 19, 2021

comius Jul 21, 2021

or-shachar commented Jul 25, 2021

Yannic commented Jun 24, 2022

Yannic commented Jun 24, 2022

ckolli5 commented Jun 27, 2022

ckolli5 commented Jun 28, 2022

junitrunner: Report suppressed and ignored tests as skipped. #13717

junitrunner: Report suppressed and ignored tests as skipped. #13717

Conversation

benjaminp commented Jul 19, 2021 • edited Loading

google-cla bot commented Jul 19, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

google-cla bot commented Jul 19, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

google-cla bot commented Jul 19, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

comius Jul 21, 2021

Choose a reason for hiding this comment

or-shachar commented Jul 25, 2021

Yannic commented Jun 24, 2022

Yannic commented Jun 24, 2022

ckolli5 commented Jun 27, 2022

ckolli5 commented Jun 28, 2022

benjaminp commented Jul 19, 2021 •

edited

Loading