Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config hash to cycle reporting, to aid debugging. #13371

Closed
wants to merge 5 commits into from
Closed

Add config hash to cycle reporting, to aid debugging. #13371

wants to merge 5 commits into from

Conversation

katre
Copy link
Member

@katre katre commented Apr 19, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Apr 19, 2021
@katre katre requested a review from janakdr April 19, 2021 14:30
janakdr
janakdr requested changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@janakdr janakdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests?

@katre
Copy link
Member Author

katre commented Apr 19, 2021

Sorry, should have let tests run before I sent this for review.

Unfortunately, the best way to fix the tests involves adding regular expression support to a lot of the existing test primitives. Do you prefer that these changes be in this PR, or split out to a separate PR?

@katre katre force-pushed the target-cycle-config branch from 131edab to 5b0a47d Compare April 19, 2021 16:49
@janakdr
Copy link
Contributor

janakdr commented Apr 19, 2021

Ok either way

@katre katre mentioned this pull request Apr 19, 2021
Closed
@katre katre force-pushed the target-cycle-config branch from 5b0a47d to 08d2b0f Compare April 19, 2021 17:23
bazel-io pushed a commit that referenced this pull request Apr 19, 2021
@katre @copybara-github
Fix regex event matching
ad90293 
This is the prerequisite to #13371.

Closes #13375.

PiperOrigin-RevId: 369286187
@bazel-io bazel-io closed this in 660e8a5 Apr 20, 2021
@katre katre deleted the target-cycle-config branch April 20, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janakdr janakdr janakdr requested changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katre @janakdr