ctexplain: make cquery parsing more robust #13212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically: - Handle labels with spaces - Handle targets with no fragment requirements. These were both inspired by real analyses. Testing: $ bazel test //tools/ctexplain:all Work towards bazelbuild#10613
sdtwigg
suggested changes
Apr 1, 2021
| if fragments_start == fragments_end - 1: | ||
| fragments = tuple() | ||
| else: | ||
| fragments = tuple(line[fragments_start + 1:fragments_end].split(", ")) |
There was a problem hiding this comment.
tuple(x.strip() for x in line[fragments_start + 1:fragments_end].split(","))
is a little more resilient to whitespace changes.
| config_hash = tokens[1][1:-1] | ||
| config_hash_start = line.find("(") | ||
| config_hash_end = line.find(")", config_hash_start) | ||
| fragments_start = line.find("[", config_hash_end) |
There was a problem hiding this comment.
move under the else: condition below; after verifying not in null configuration
| success = res[0] | ||
| cts = res[2] | ||
| self.assertTrue(success) | ||
| self.assertEqual(len(cts), 1) |
| success = res[0] | ||
| cts = res[2] | ||
| self.assertTrue(success) | ||
| self.assertEqual(len(cts), 1) |
| self.assertTrue(success) | ||
| self.assertEqual(len(cts), 1) | ||
| self.assertEqual(cts[0].label, '//testapp:alias_to_src') | ||
| self.assertEqual(len(cts[0].transitive_fragments), 0) |
|
Hi all, we're doing a clean up of old PRs and will be closing this one since it seems to have stalled. Please feel free to reopen if you’re still interested in pursuing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically:
These were both inspired by real analyses.
Testing:
$ bazel test //tools/ctexplain:allWork towards #10613