Add external_include_paths C++ feature #13107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeea88e to
6f709cd
Compare
Projects with strict warnings level experience issues when they depend on third party libraries with less-strict warnings: The compiler will emit warnings for external sources. See bazelbuild#12009 for more. This change optionally silences those warnings, by changing -I flags to -isystem flags and by adding -isystem flags for each -iquote flag, in case of external dependencies, i.e: those targets that come from a non-main workspace. The new behavior can be enabled by --features=external_include_paths, otherwise there's no functional change. The default flag_group in unix_cc_toolchain_config will silence warnings coming from -I and -iquote dirs in case of GCC, and -I for Clang. Clang will still produce warnings for -iquote dirs, therefore the Clang specific --system-header-prefix is recommended instead.
|
Gentel reminder. |
|
@oquenchil Are you going to approve and merge? |
tpudlik
added a commit
to tpudlik/rules_cc_toolchain
that referenced
this pull request
Feb 3, 2023
This useful feature was added to the default Bazel C++ toolchain in Bazel 5.0; see bazelbuild/bazel#13107. Fixes bazelembedded#46
tpudlik
added a commit
to tpudlik/rules_cc_toolchain
that referenced
this pull request
Feb 3, 2023
This useful feature was added to the default Bazel C++ toolchain in Bazel 5.0; see bazelbuild/bazel#13107. Fixes bazelembedded#46
tpudlik
added a commit
to tpudlik/rules_cc_toolchain
that referenced
this pull request
Feb 3, 2023
This useful feature was added to the default Bazel C++ toolchain in Bazel 5.0; see bazelbuild/bazel#13107. Fixes bazelembedded#46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projects with strict warnings level experience issues when they depend on third party libraries with less-strict warnings: The compiler will emit warnings for external sources. See #12009 for more.
This change optionally silences those warnings, by changing -I flags to -isystem flags and by adding -isystem flags for each -iquote flag, in case of external dependencies, i.e: those targets that come from a non-main workspace.
The new behavior can be enabled by --features=external_include_paths, otherwise there's no functional change.
The default flag_group in unix_cc_toolchain_config will silence warnings coming from -I and -iquote dirs in case of GCC, and -I for Clang. Clang will still produce warnings for -iquote dirs, therefore the Clang specific --system-header-prefix is recommended instead.