Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce visibility on select() keys #12877

Closed
wants to merge 5 commits into from
Closed

Enforce visibility on select() keys #12877

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
520f30a
Enforce visibility on select() keys.
gregestren Jan 22, 2021
337d983
Review feedback.
gregestren Jan 27, 2021
39bbfba
Update doc feedback.
gregestren Jan 27, 2021
290c26c
Minor formatting fix.
gregestren Jan 27, 2021
3b9f2e2
Doc update.
gregestren Jan 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update doc feedback.
  • Loading branch information
@gregestren
gregestren committed Jan 27, 2021
commit 39bbfbaba413d99a900b7c94b719e8b8c5b8efc4
7 changes: 5 additions & 2 deletions site/docs/visibility.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,12 @@ specified in the [`package`](be/functions.html#package) statement of the
target's BUILD file. If there is no such `default_visibility` declaration, the
visibility is `//visibility:private`.

`config_setting` targets default to `//visibility:public`. This is purely for
`config_setting` targets default to `//visibility:public, regardless of how the
package's [`default_visibility`](be/functions.html#package.default_visibility)
is set. This is purely for
legacy reasons. Best practice is to treat `config_setting` targets as if they
also use the private default.
use the private default: any `config_setting` intended for use by other packages
should set its visibility explicitly.

### Example

Expand Down