Remove C++ linking from oso_prefix feature for now #12356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in the macOS toolchain C++ linking goes through `cc_wrapper.sh`, not `wrapped_clang`. I didn't add the handling to `cc_wrapper` for this argument. These wrappers will likely go away soon, when they do we should probably make them route to wrapped_clang instead, in which case we could revert this. bazelbuild#12304
|
Is this blocked on #12304 or should it happen first? |
|
Not blocked. We can potentially revert this after that lands, but it depends if that works, and since it sounds like it requires a flag it will take long enough that I think this is worth merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the macOS toolchain C++ linking goes through
cc_wrapper.sh, notwrapped_clang. I didn't add the handling tocc_wrapperfor this argument. These wrappers will likely go away soon,when they do we should probably make them route to wrapped_clang
instead, in which case we could revert this.
#12304