Windows: Remove read-only attribute for directory before deleting #11982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If some directory is set to read-only on Windows, DeletePath will fail to delete that directory even when no one else is using it. Previously, we only remote read-only attribute for files before deleting, we should also do the same for deleting directory. Fixes bazelbuild/continuous-integration#1012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If some directory is set to read-only on Windows, DeletePath will fail
to delete that directory even when no one else is using it.
Previously, we only remove the read-only attribute for files before
deleting, we should also do the same for deleting directory.
Fixes bazelbuild/continuous-integration#1012