Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use target config for toolchain #10694

Closed
wants to merge 1 commit into from

Conversation

eagleonhill
Copy link

Toolchain typically contains two parts: Compiler and runtime.
Runtime should be using target config.
For compilers that needs host/exec config, the toolchain should do own
transition.

Currently the toolchain is using host config if enabled new toolchain
resolution, which caused the runtime not able to be linked as expected.

Toolchain typically contains two parts: Compiler and runtime.
Runtime should be using target config.
For compilers that needs host/exec config, the toolchain should do own
transition.

Currently the toolchain is using host config if enabled new toolchain
resolution, which caused the runtime not able to be linked as expected.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@eagleonhill eagleonhill requested a review from lberki February 3, 2020 02:38
@lberki lberki requested review from katre and removed request for lberki February 3, 2020 08:34
@katre
Copy link
Member

katre commented Feb 3, 2020

This is a known issue that has been reported several times (see #4067 and #6889). Unfortunately, simply using the target configuration is also not always correct: consider the case of a toolchain that wants to build the compiler itself (which would need to use the exec configuration).

I have proposed a solution called Toolchain Transitions which allows for both cases, and I have opened an issue tracking that work (#10523).

I am closing this PR but please read the proposal and leave any comments on #10523 if there is a case that isn't covered there.

@katre katre closed this Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants