Remove --python_path flag
#7901
Labels
P3
We're not considering working on this, but happy to review a PR. (No assignee)
stale
Issues or PRs that are stale (no activity for 30 days)
team-Rules-Python
Native rules for Python
type: process
Comments
|
Blocked in part on #7844. |
|
Looks like there's some background on the windows workaround in #3717. |
bazel-io
pushed a commit
that referenced
this issue
Mar 30, 2019
This renames --experimental_use_python_toolchains to --incompatible. It also adds the behavior to the flag that 1) py_runtime's python_version attribute becomes manadatory, and 2) the --python_top flag is disallowed (it is superseded by toolchains), as well as --python2_path and --python3_path (they were already no-ops). --python_path is strongly discouraged but not yet banned due to an existing use on Windows (#7901). Feature issue is #7375, incompatible change migration issue is #7899. RELNOTES[INC]: Introduced --incompatible_use_python_toolchains, which supersedes --python_top/--python_path. See #7899 and #7375 for more information. PiperOrigin-RevId: 241134532
|
Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This had to be broken out of #7375 because it turns out
python_pathis used on windows to communicate the location of the Python interpreter even when it's not otherwise available on thePATHat execution time.We can possibly switch this bit of client-server communication to use a hidden flag in place of
--python_path. Alternatively (and probably preferably), we can replace this logic with a repo rule that detects the host platform's Python interpreter, and feed that into the Python toolchain. Another option is to deprecate this bit of niceness and instead require that the interpreter either be available onPATHat execution time or else have its path embedded into an appropriatepy_runtimeof a toolchain definition.The text was updated successfully, but these errors were encountered: