Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup flags and code paths for legacy Python version api and semantics #7797

Closed
brandjon opened this issue Mar 21, 2019 · 2 comments
Closed
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Python Native rules for Python type: process

Comments

@brandjon
Copy link
Member

Tracking bug for deleting --incompatible_remove_old_python_version_api, --incompatible_allow_python_version_transitions, and the code supporting these flags.

The flags are being flipped in Bazel 0.25. Google still uses these flags internally, but we expect to be migrated for them soon as well, so this might happen in the near term (O(weeks)).

Corresponds to implemented feature #6583.

@brandjon brandjon added P3 We're not considering working on this, but happy to review a PR. (No assignee) type: process team-Rules-Python Native rules for Python labels Mar 21, 2019
bazel-io pushed a commit that referenced this issue Mar 24, 2020
The flag now behaves as if it is always unset. It will be removed entirely in a separate CL. In the meantime, it is still disallowed to select() on the flag.

Work toward #7797.

RELNOTES: None
PiperOrigin-RevId: 302665836
bazel-io pushed a commit that referenced this issue Mar 24, 2020
--force_python has been made a no-op, so there's no need for
@bazel_tools//tools/python:python_version to consider it.

Work toward #7797.

RELNOTES: None
PiperOrigin-RevId: 302676532
bazel-io pushed a commit that referenced this issue Mar 26, 2020
This flag enabled the new flexible Python version semantics, from the old --force_python way of doing things. It's been flipped for quite some time. This change deletes its remaining uses in tests and makes it a no-op.

Work toward #7797.

RELNOTES: None
PiperOrigin-RevId: 303172288
bazel-io pushed a commit that referenced this issue Mar 27, 2020
This flag blocked use of the old --force_python flag, and the old default_python_version attribute. It has long since been flipped. This change deletes its uses in tests and its legacy code paths.

Work toward #7797.

RELNOTES: None
PiperOrigin-RevId: 303229827
@brandjon
Copy link
Member Author

--force_python, --incompatible_remove_old_python_version_api, and --incompatible_allow_python_version_transitions are now all no-ops. Still need to remove the actual flags themselves.

@sgowroji sgowroji added the stale Issues or PRs that are stale (no activity for 30 days) label Feb 16, 2023
@sgowroji
Copy link
Member

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

@sgowroji sgowroji closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Python Native rules for Python type: process
Projects
None yet
Development

No branches or pull requests

2 participants