Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TestRunnerAction in aquery #7647

Closed
meisterT opened this issue Mar 6, 2019 · 1 comment
Closed

Support TestRunnerAction in aquery #7647

meisterT opened this issue Mar 6, 2019 · 1 comment
Assignees
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Performance Issues for Performance teams type: feature request

Comments

@meisterT
Copy link
Member

meisterT commented Mar 6, 2019

Right now we neither display command lines nor environment variables in bazel aquery because TestRunnerAction does not subclass SpawnAction.

We can get command lines from here:
https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/exec/TestStrategy.java#L140
and the environment variables from here:
https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/analysis/test/TestRunnerAction.java#L498

@meisterT meisterT added type: feature request P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Performance Issues for Performance teams labels Mar 6, 2019
@finnball
Copy link

finnball commented Mar 6, 2019

For more context, I would like to be able to find the binary how it will be executed when tested without actually running it.

As an example, if I run:

bazel test -s //absl/algorithm:algorithm_test

It will output:

(cd /home/me/.cache/bazel/_bazel_finn/465e7e526733cb116d77f110a062bc6e/execroot/com_google_absl && \
  exec env - \
  <snip> input variables </snip> \
  external/bazel_tools/tools/test/test-setup.sh absl/algorithm/algorithm_test)

It would be useful if there were an easy way to get this information without having to execute the test.

@meisterT meisterT self-assigned this Aug 7, 2019
bazel-io pushed a commit that referenced this issue Dec 2, 2019
We achieve this by making TestRunnerAction implements the CommandAction
interface.

Fixes #7647
RELNOTES: None
PiperOrigin-RevId: 283306323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Performance Issues for Performance teams type: feature request
Projects
None yet
Development

No branches or pull requests

3 participants