Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel CI: flipping --incompatible_use_toolchain_providers_in_java_common broke downstream #7537

Closed
meteorcloudy opened this issue Feb 26, 2019 · 3 comments
Closed

Bazel CI: flipping --incompatible_use_toolchain_providers_in_java_common broke downstream #7537

meteorcloudy opened this issue Feb 26, 2019 · 3 comments
Assignees
@cushon
Labels
breakage P1 I'll work on this now. (Assignee required)

Comments

@meteorcloudy
Copy link
Member

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/825#_

ERROR: /home/bazel/.cache/bazel/_bazel_bazel/5d706025d280d5fdbb05fa8927483c8f/external/io_bazel_rules_scala/third_party/dependency_analyzer/src/main/BUILD:5:1: in scala_library_for_plugin_bootstrapping rule @io_bazel_rules_scala//third_party/dependency_analyzer/src/main:dependency_analyzer:
--
  | Traceback (most recent call last):
  | File "/home/bazel/.cache/bazel/_bazel_bazel/5d706025d280d5fdbb05fa8927483c8f/external/io_bazel_rules_scala/third_party/dependency_analyzer/src/main/BUILD", line 5
  | scala_library_for_plugin_bootstrapping(name = 'dependency_analyzer')
  | File "/home/bazel/.cache/bazel/_bazel_bazel/5d706025d280d5fdbb05fa8927483c8f/external/io_bazel_rules_scala/scala/private/rule_impls.bzl", line 753, in scala_library_for_plugin_bootstrapping_impl
  | _lib(ctx, scalac_provider.default_class..., <3 more arguments>)
  | File "/home/bazel/.cache/bazel/_bazel_bazel/5d706025d280d5fdbb05fa8927483c8f/external/io_bazel_rules_scala/scala/private/rule_impls.bzl", line 676, in _lib
  | _compile_or_empty(ctx, ctx.outputs.manifest, cjars, srcj..., <6 more arguments>)
  | File "/home/bazel/.cache/bazel/_bazel_bazel/5d706025d280d5fdbb05fa8927483c8f/external/io_bazel_rules_scala/scala/private/rule_impls.bzl", line 461, in _compile_or_empty
  | java_common.run_ijar(ctx.actions, jar = ctx.outputs.jar, <2 more arguments>)
  | ConfiguredTarget(@bazel_tools//tools/jdk:current_java_toolchain, a9bf8afaa53ba87d4539f7a4ad4bf485) pass a java_common.JavaToolchainInfo instead of a configured target; see https://github.com/bazelbuild/bazel/issues/7186.
@meteorcloudy meteorcloudy added P1 I'll work on this now. (Assignee required) breakage labels Feb 26, 2019
@meteorcloudy
Copy link
Member Author

meteorcloudy commented Feb 26, 2019 •
edited
Loading

Culprit is 993c484
https://buildkite.com/bazel/culprit-finder/builds/114#bee4b0a0-0983-495e-be6a-7292ed47573f

@meteorcloudy
Copy link
Member Author

meteorcloudy commented Feb 26, 2019 •
edited
Loading

Looks like --incompatible_use_toolchain_providers_in_java_common should not be flipped at this time, because 0.23.0 is the migration window for it. We should not flip a flag until downstream has migrated. I'm rolling back the CL.

bazel-io pushed a commit that referenced this issue Feb 26, 2019
@meteorcloudy @copybara-github
Automated rollback of commit 993c484.
ce74927 
*** Reason for rollback ***

Broke Bazel CI: #7537

*** Original change description ***

Enable --incompatible_use_toolchain_providers_in_java_common

Fixes #7186

RELNOTES: incompatible_use_toolchain_providers_in_java_common: pass JavaToolchainInfo and JavaRuntimeInfo providers to java_common APIs instead of configured targetshttps://github.com//issues/7186.
PiperOrigin-RevId: 235684551
@cushon
Copy link
Contributor

cushon commented Feb 26, 2019

We should not flip a flag until downstream has migrated.

The flip hadn't been released yet; the flag was flipped after the baseline was cut for 0.23.

@cushon cushon closed this as completed Feb 26, 2019
@cushon cushon mentioned this issue Mar 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cushon cushon

Labels
breakage P1 I'll work on this now. (Assignee required)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cushon @meteorcloudy