Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbounded thread pool in ByteStreamBuildEventArtifactUploader #6806

Closed
ulfjack opened this issue Nov 30, 2018 · 5 comments
Closed

Unbounded thread pool in ByteStreamBuildEventArtifactUploader #6806

ulfjack opened this issue Nov 30, 2018 · 5 comments
Assignees
@meteorcloudy @lfpino
Labels
P1 I'll work on this now. (Assignee required) type: bug

Comments

@ulfjack
Copy link
Contributor

ulfjack commented Nov 30, 2018

It's possible that this is causing our CI to be flaky.
@ulfjack ulfjack added type: bug P1 I'll work on this now. (Assignee required) release blocker labels Nov 30, 2018
@ulfjack
Copy link
Contributor Author

ulfjack commented Nov 30, 2018

@meteorcloudy has a patch at:
377670e

@lfpino
Copy link
Contributor

lfpino commented Nov 30, 2018

For reference, the unbounded thread pool is located at:

bazel/src/main/java/com/google/devtools/build/lib/remote/ByteStreamBuildEventArtifactUploader.java

Line 45 in 48b672c

MoreExecutors.listeningDecorator(Executors.newCachedThreadPool());

@meteorcloudy
Copy link
Member

@ulfjack Do you want me to submit this change?

@ulfjack
Copy link
Contributor Author

ulfjack commented Nov 30, 2018

Yes, ASAP.

@ulfjack
Copy link
Contributor Author

ulfjack commented Nov 30, 2018

:-D

bazel-io pushed a commit that referenced this issue Dec 4, 2018
@meteorcloudy
Add --build_event_upload_max_threads option
798b9a9 
This is a follow up for 7fc967c, related issue #6806

RELNOTES: None
PiperOrigin-RevId: 223944430
@meteorcloudy meteorcloudy mentioned this issue Dec 6, 2018
Closed
laurentlb pushed a commit that referenced this issue Dec 14, 2018
@meteorcloudy @laurentlb
Use a fixed thread pool in ByteStreamBuildEventArtifactUploader
021fc18 
Fixes #6806

RELNOTES: None
PiperOrigin-RevId: 223763834
laurentlb pushed a commit that referenced this issue Dec 14, 2018
@meteorcloudy @laurentlb
Add --build_event_upload_max_threads option
682ffdf 
This is a follow up for 7fc967c, related issue #6806

RELNOTES: None
PiperOrigin-RevId: 223944430
laurentlb pushed a commit that referenced this issue Dec 17, 2018
@meteorcloudy @laurentlb
Use a fixed thread pool in ByteStreamBuildEventArtifactUploader
d78cec4 
Fixes #6806

RELNOTES: None
PiperOrigin-RevId: 223763834
laurentlb pushed a commit that referenced this issue Dec 17, 2018
@meteorcloudy @laurentlb
Add --build_event_upload_max_threads option
83fcb31 
This is a follow up for 7fc967c, related issue #6806

RELNOTES: None
PiperOrigin-RevId: 223944430
@moroten moroten mentioned this issue Jan 16, 2020
Closed
@oehme oehme mentioned this issue Oct 15, 2021
Closed
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Add --build_event_upload_max_threads option
ab91e4c 
    This is a follow up for bazelbuild/bazel@7fc967c, related issue bazelbuild/bazel#6806

    RELNOTES: None
    PiperOrigin-RevId: 223944430
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Use a fixed thread pool in ByteStreamBuildEventArtifactUploader
3058adc 
    Fixes bazelbuild/bazel#6806

    RELNOTES: None
    PiperOrigin-RevId: 223763834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meteorcloudy meteorcloudy

@lfpino lfpino

Labels
P1 I'll work on this now. (Assignee required) type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@meteorcloudy @ulfjack @lfpino