Support http caching for query

[abergmeier-dsfishlabs]

Description of the problem / feature request / question:

Trying to pass experimental_repository_cache to bazel query complains that the option is not supported. This means that offline querying is not possible.

Environment info

• Operating System: Ubuntu 16.04.2
• Bazel version (output of bazel info release): 0.4.3

Have you found anything relevant by searching the web?

Nope

[abergmeier-dsfishlabs]

Maybe it would be good to have a meta-issue so all options of build get supported for query, too. AFAIR there are more options not working for query.

[kchodorow]

FWIW, --experimental_repository_cache only adds additional caching between bazel projects. Bazel caches external repositories regardless, it just doesn't share them between various workspaces on your machine.

[abergmeier-dsfishlabs]

--experimental_repository_cache only adds additional caching between bazel projects. Bazel caches external repositories regardless, it just doesn't share them between various workspaces on your machine.

When I build with experimental_repository_cache and then query without, it tries to download the http_archive. This then breaks working offline.

[kchodorow]

Hmm, that is a more serious bug. Definitely not intended.

[laszlocsomor]

@abergmeier-dsfishlabs :

Maybe it would be good to have a meta-issue so all options of build get supported for query, too. AFAIR there are more options not working for query.

See #3054

[laszlocsomor]

@kchodorow, @damienmg : Is this really P1? If so, let's find an assignee and milestone. If not, let's demote to P2 or P3.

[damienmg]

Well I don't think this is a P1 until fixing repository caching becomes a P1 again... (IMO it should be but we have so many P1...)

[laszlocsomor]

Thanks! Dropped the priority.

we have so many P1

Yes, and as this week's sheriff I feel uncomfortable with that :)

[aehlig]

First remark: http_archive does enough caching so that bazel query works also offline for every repository that was accessed while being online (see https://bazel-review.googlesource.com/c/bazel/+/33750/). So we can probably change the priority.

Second: In fact, a quick test with the release candidate of 0.10.0 shows that --experimental_repository_chache is supported for bazel query and does the caching one expects. So, it seems someone already implemented that feature request without closing the issue. Will add a test to ensure it stays that way.