Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0] Symbolic macro attribute inheritance #24335

Closed
bazel-io opened this issue Nov 14, 2024 · 1 comment
Closed

[8.0.0] Symbolic macro attribute inheritance #24335

bazel-io opened this issue Nov 14, 2024 · 1 comment
Milestone
8.0.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #24066
@bazel-io bazel-io added this to the 8.0.0 release blockers milestone Nov 14, 2024
@tetromino tetromino mentioned this issue Nov 14, 2024
Merged
@tetromino
Copy link
Contributor

Cherry-pick in #24336

github-merge-queue bot pushed a commit that referenced this issue Nov 15, 2024
@tetromino
[8.0.0] Put macro attribute inheritance behind an off-by-default --ex…
94bdee2 
…perimental_enable_macro_inherit_attrs flag (#24336)

We still have open questions about how macro attribute inheritance ought
to interact with the tracking of whether rule attributes were or were
not explicitly provided.

In effect, this re-opens
#24066 Part of addressing
#24319

RELNOTES: symbolic macro attribute inheritance is now marked
experimental; set --experimental_enable_macro_inherit_attrs flag to
enable it.

Commit

08beb21

PiperOrigin-RevId: 696582223
Change-Id: I3d7cb434bf8fe2da9cd10019e6075990205e7153

Working towards #24335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0 release blockers
Development

No branches or pull requests
3 participants
@tetromino @bazel-io @iancha1992