-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a platform rule to simplify toolchain selection logic #2219
Comments
platform-related constraints and values. Part of ongoing work on bazelbuild#2219.
platform-related constraints and values. Part of ongoing work on bazelbuild#2219. Change-Id: Ice370ee26469f4992faf72c0c95a1a3e51a9f9e7
values. Part of ongoing work on bazelbuild#2219. Change-Id: Ie4e842a5d8218e47f41a954c2b955ab24237aa65
values. Part of ongoing work on bazelbuild#2219. Change-Id: Ie4e842a5d8218e47f41a954c2b955ab24237aa65
values. Part of ongoing work on bazelbuild#2219. Change-Id: Ie4e842a5d8218e47f41a954c2b955ab24237aa65
platform-related constraints and values. Part of ongoing work on #2219. -- Change-Id: Ice370ee26469f4992faf72c0c95a1a3e51a9f9e7 Reviewed-on: https://cr.bazel.build/9091 PiperOrigin-RevId: 148758190 MOS_MIGRATED_REVID=148758190
values. Part of ongoing work on bazelbuild#2219. Change-Id: Ie4e842a5d8218e47f41a954c2b955ab24237aa65
…values. Part of ongoing work on #2219. -- Change-Id: Ie4e842a5d8218e47f41a954c2b955ab24237aa65 Reviewed-on: https://cr.bazel.build/9116 PiperOrigin-RevId: 148976893 MOS_MIGRATED_REVID=148976893
Part of #2219. -- Change-Id: Id82bdd5b3dfab1d2ea781d27dd98020966ce8fac Reviewed-on: https://cr.bazel.build/9271 PiperOrigin-RevId: 149782572 MOS_MIGRATED_REVID=149782572
…s//platforms. Part of #2219. -- Change-Id: I312c70e0c9064cbf4c4346a59bff04ada92e4890 Reviewed-on: https://cr.bazel.build/9412 PiperOrigin-RevId: 151016060 MOS_MIGRATED_REVID=151016060
I've gotten bad about tagging this issue in commits, so mentioning them here for tracking: 34efd79 Rename ToolchainLookup rule to ToolchainType, to better explain the usage of the rule. |
Part of bazelbuild#2219. Change-Id: I87c7bc9fbfb38d3dbdf193b46247901d0f2a838d
Part of bazelbuild#2219. Change-Id: Ia559d0770cbe82baca3f3259018a851a4cf30f22
Part of bazelbuild#2219. Change-Id: I4d749dd9981fe33f75310acb0ec3927cff6f28fe
Part of bazelbuild#2219. Change-Id: Ifd8aacef04bfbe2aa25eec7551803dc6e6a59ce5
Part of bazelbuild#2219. Experimental, DO NOT SUBMIT. Change-Id: I101bb9fbaab0debb20b9bc07fca3b0dc4b9ff66b
Part of bazelbuild#2219. Change-Id: I87c7bc9fbfb38d3dbdf193b46247901d0f2a838d
Part of bazelbuild#2219. Change-Id: Ia559d0770cbe82baca3f3259018a851a4cf30f22
Part of bazelbuild#2219. Change-Id: I4d749dd9981fe33f75310acb0ec3927cff6f28fe
Added Functions: TKTKTK Part of bazelbuild#2219. Change-Id: Iba9e2d3e2171af3bc8b93df72d76c95ab2a26f0c
Part of bazelbuild#2219. Change-Id: Ifd8aacef04bfbe2aa25eec7551803dc6e6a59ce5
Part of bazelbuild#2219. Experimental, DO NOT SUBMIT. Change-Id: I101bb9fbaab0debb20b9bc07fca3b0dc4b9ff66b
…azel. Part of bazelbuild#2219. Change-Id: I76f3ebe88bd687c8b9ec47b91743a1cb724ec16f
Part of bazelbuild#2219. Change-Id: I339009c13639144ca756eb07c520df7d430a64e3
Part of bazelbuild#2219. Change-Id: Id4929d5ddcd57b4635af5e513eb9a09f16a78e71
Part of #2219. Change-Id: I87c7bc9fbfb38d3dbdf193b46247901d0f2a838d PiperOrigin-RevId: 154719063
Part of bazelbuild#2219. Change-Id: Id4929d5ddcd57b4635af5e513eb9a09f16a78e71
Part of #2219. Change-Id: Ia0effac6e6c362c04c6501b21dde89e9e5b154a4 PiperOrigin-RevId: 161216492
…lchains to use. Part of bazelbuild#2219. Change-Id: Id6dfe6ec102f609bb19461242a098bf977be29ae
Part of bazelbuild#2219. Change-Id: I7293fd13bd8e0931f92afd051e18a9e7ce63762d
Part of bazelbuild#2219. Change-Id: I339009c13639144ca756eb07c520df7d430a64e3
Part of bazelbuild#2219. Change-Id: I5777e9b6cafbb7586cbbfb5b300344fd4417513d
Part of bazelbuild#2219. Change-Id: Id4929d5ddcd57b4635af5e513eb9a09f16a78e71
…lchains to use. Part of #2219. Change-Id: Id6dfe6ec102f609bb19461242a098bf977be29ae PiperOrigin-RevId: 161527986
Part of bazelbuild#2219. Change-Id: I7293fd13bd8e0931f92afd051e18a9e7ce63762d
Part of bazelbuild#2219. Change-Id: I339009c13639144ca756eb07c520df7d430a64e3
Part of bazelbuild#2219. Change-Id: I5777e9b6cafbb7586cbbfb5b300344fd4417513d
Part of bazelbuild#2219. Change-Id: Id4929d5ddcd57b4635af5e513eb9a09f16a78e71
Part of #2219. Change-Id: I7293fd13bd8e0931f92afd051e18a9e7ce63762d PiperOrigin-RevId: 161721445
Part of bazelbuild#2219. Change-Id: I339009c13639144ca756eb07c520df7d430a64e3
Part of bazelbuild#2219. Change-Id: I5777e9b6cafbb7586cbbfb5b300344fd4417513d
Part of bazelbuild#2219. Change-Id: Id4929d5ddcd57b4635af5e513eb9a09f16a78e71
Part of bazelbuild#2219. Change-Id: I4b6358742e614f3f447abf0dabf3c9344a64a236
Part of #2219. Change-Id: I339009c13639144ca756eb07c520df7d430a64e3 PiperOrigin-RevId: 161826487
Thank you for writing this up! I was wondering about a possible use case. The Go race detector is turned on when It would be nice if we didn't have to create new targets that flipped on the Go race detector on for itself and its deps, but instead could just pass in a CLI flag that chose the platform with the race detector flag set on its compiler and linker. Is that a feature that will exist? |
Oh, jeez, right on the next page is the answer laid out in the tensorflow example: yes. Thanks again for writing all this down. Very helpful while I consider what to do about bazel-contrib/rules_go#167 |
Part of #2219. Change-Id: I5777e9b6cafbb7586cbbfb5b300344fd4417513d PiperOrigin-RevId: 162359389
Part of #2219. Change-Id: Id4929d5ddcd57b4635af5e513eb9a09f16a78e71 PiperOrigin-RevId: 162634398
The platform rules exist, and work is continuing in #4442 , so closing this issue. |
Tracking issue for the work to add platforms and better toolchain selection to Bazel.
See the design document at https://docs.google.com/document/d/1-G-VPRLEj9VyfC6VrQBiR8To-dZjnBSQS66Y4nargGM/edit?ts=57df9619#heading=h.al54v2ddwqzv for more details.
The text was updated successfully, but these errors were encountered: