Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Bazel to be built and tested with Bzlmod enabled #18957

Closed
9 tasks done
meteorcloudy opened this issue Jul 17, 2023 · 0 comments
Closed
9 tasks done

Migrate Bazel to be built and tested with Bzlmod enabled #18957

meteorcloudy opened this issue Jul 17, 2023 · 0 comments
Assignees
@meteorcloudy
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests P1 I'll work on this now. (Assignee required) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request
Milestone
7.0.0 branch cut

Comments

@meteorcloudy
Copy link
Member

meteorcloudy commented Jul 17, 2023 •
edited
Loading

Bzlmod is getting mature in Bazel 6, it's time for projects to fully adopt Bzlmod, same apply for Bazel itself.

Identified task list:
@meteorcloudy meteorcloudy added type: feature request P1 I'll work on this now. (Assignee required) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website area-Bzlmod Bzlmod-specific PRs, issues, and feature requests labels Jul 17, 2023
@meteorcloudy meteorcloudy self-assigned this Jul 17, 2023
@github-project-automation github-project-automation bot moved this to Todo in Bzlmod Jul 17, 2023
@Wyverald Wyverald added this to the 7.0.0 branch cut milestone Jul 17, 2023
@meteorcloudy meteorcloudy added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. and removed team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Jul 18, 2023
This was referenced Jul 25, 2023
Closed
Closed
copybara-service bot pushed a commit that referenced this issue Jul 26, 2023
@meteorcloudy @copybara-github
Fetching testparameterinjector and snakeyaml using rules_jvm_external
2192a05 
Working towards #18957

Closes #19084.

PiperOrigin-RevId: 551173479
Change-Id: Ib3c9956b81af8552de2af0f1abdb78bd212041d3
@meteorcloudy meteorcloudy mentioned this issue Jul 27, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Aug 1, 2023
@meteorcloudy @copybara-github
integration_test_setup.sh: load bash runfiles library
b20085a 
Instead of getting the rlocation function from [test-setup.sh](https://cs.opensource.google/bazel/bazel/+/master:tools/test/test-setup.sh;l=115), we should use the actual bash runfiles library which supports repo mapping.

Working towards: #18957

RELNOTES: None
PiperOrigin-RevId: 552778831
Change-Id: Ie747faf58a5c3fc33d38653130d9657224909430
copybara-service bot pushed a commit that referenced this issue Aug 1, 2023
@meteorcloudy @copybara-github
Introduce more dependencies in Bazel Bzlmod build
cf14039 
Working towards: #18957

RELNOTES:
PiperOrigin-RevId: 552886589
Change-Id: I2d170deae5bdaf05dbece4779ffb5b1137ee7b81
copybara-service bot pushed a commit that referenced this issue Aug 4, 2023
@meteorcloudy @copybara-github
test_base.py: use bazel-runfiles to respect repo mappings
b66b8c5 
Use rules_python to fetch the bazel-runfiles pip package, we can later migrate other checked-in Python deps to rules_python as well.

On linux and macOS, we are using a hermetic Python toolchain fetched by rules_python, which helped avoid issues with older system installed Python version (<=3.6) on centos7 and ubuntu1804.

On windows, the hermetic Python toolchain doesn't work with `pywin32` pip package, therefore we still use the auto-detected python toolchain.

For bootstrapping test, we need to use the auto-detected python toolchain to avoid downloading Python.

Working towards: #18957

RELNOTES:
PiperOrigin-RevId: 553731631
Change-Id: I605399067e21653cab707694810de24fd2109c41
copybara-service bot pushed a commit that referenced this issue Aug 9, 2023
@meteorcloudy @copybara-github
Fix copybara to also transform tests with strange names.
7a489b1 
Working towards: #18957

PiperOrigin-RevId: 555218827
Change-Id: I43dd9a581bec70f179c07d98f2f17d1cb4e4252e
copybara-service bot pushed a commit that referenced this issue Sep 4, 2023
@meteorcloudy @copybara-github
Fix condition for Windows
3ae0eb4 
//src:windows is deprecated a long time ago.

Working towards: #18957

RELNOTES:
PiperOrigin-RevId: 562568893
Change-Id: I193c9168c278368f682eef71c08eb6bc20a3fb3a
copybara-service bot pushed a commit that referenced this issue Sep 5, 2023
@meteorcloudy @copybara-github
Avoid using io_bazel directly
dddf3d0 
Working towards #18957

RELNOTES: None
PiperOrigin-RevId: 562743741
Change-Id: Iaef46f0a67d264968f399805da7f5cf9566cb035
@meteorcloudy meteorcloudy mentioned this issue Sep 5, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Sep 5, 2023
@meteorcloudy @copybara-github
Update android_tools for Bzlmod
f603d16 
Working towards: #18957

RELNOTES:
PiperOrigin-RevId: 562768107
Change-Id: I7ddbb864ee77789bba64509fea980340e6ab5c49
copybara-service bot pushed a commit that referenced this issue Sep 6, 2023
@meteorcloudy @copybara-github
Prepare for Bazel Bzlmod build
b27ca73 
Working towards: #18957

- Updated MODULE.bazel and distdir_deps.bzl to match all dependencies
- Introduced the repo_cach_tar rule to help with boostrap build later.
- Introduced the test_repo_extension extension to prefetch testing dependencies.
- Use --experimental_downloader_config to overcome potential github.com instability.

RELNOTES: None.
PiperOrigin-RevId: 563045981
Change-Id: I8726a838bfe55908d87d17063121863f604e6211
@github-project-automation github-project-automation bot moved this from Todo to Done in Bzlmod Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meteorcloudy meteorcloudy

Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests P1 I'll work on this now. (Assignee required) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request
Projects
Bzlmod
Archived in project
Milestone
7.0.0 branch cut
Development

Successfully merging a pull request may close this issue.

Enable Bzlmod for Bazel meteorcloudy/bazel
2 participants
@Wyverald @meteorcloudy