Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 17 toolchain support #13416

Closed
davido opened this issue Apr 30, 2021 · 2 comments
Closed

Java 17 toolchain support #13416

davido opened this issue Apr 30, 2021 · 2 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-Java Issues for Java rules type: feature request

Comments

@davido
Copy link
Contributor

davido commented Apr 30, 2021

Description of the problem / feature request:

Support for java 17 to be used with toolchain resolution for java rules, e.g. with this section in .bazelrc:

# Builds using remote_jdk17, executes using remote_jdk17 or local_jdk
build:java17 --java_language_version=17
build:java17 --java_runtime_version=17
build:java17 --tool_java_language_version=17
build:java17 --tool_java_runtime_version=17

This build command should fetch remote JDK 17 and produce major java version 17:

  $ bazeldev build --config=java17 gerrit

Feature requests: what underlying problem are you trying to solve with this feature?

Build Java code and produce major java version 17.

According to JDK 17 release schedule: [1] the general availability will be available on
2021/09/14.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

  $ bazeldev build \
  --java_language_version=17 \
  --java_runtime_version=17 \
  --tool_java_language_version=17 \
  --tool_java_runtime_version=17 \
  gerrit

What operating system are you running Bazel on?

Linux.

What's the output of bazel info release?

Bazel@HEAD, Next major Bazel release (5.x) should include this feature.

[1] https://openjdk.java.net/projects/jdk/17

@comius comius added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels May 5, 2021
cushon added a commit to cushon/bazel that referenced this issue Sep 27, 2021
cushon added a commit to cushon/bazel that referenced this issue Sep 27, 2021
cushon added a commit to cushon/bazel that referenced this issue Sep 28, 2021
bazel-io pushed a commit that referenced this issue Sep 30, 2021
#13965
#13416

Closes #14040.

PiperOrigin-RevId: 399931601
@cushon
Copy link
Contributor

cushon commented Sep 30, 2021

eb7bf8c

@cushon cushon closed this as completed Sep 30, 2021
@asv
Copy link

asv commented Oct 1, 2021

Will this change be ported to the 4.x branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-Java Issues for Java rules type: feature request
Projects
None yet
Development

No branches or pull requests

5 participants