Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_lcov_merger late-bound test attribute #10642

Closed
keith opened this issue Jan 23, 2020 · 1 comment
Closed

_lcov_merger late-bound test attribute #10642

keith opened this issue Jan 23, 2020 · 1 comment
Labels
coverage P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-Server Issues for serverside rules included with Bazel type: feature request

Comments

@keith
Copy link
Member

keith commented Jan 23, 2020

I went to add _lcov_merger as an attribute for iOS tests here bazelbuild/rules_apple#691 and there was some discussion about making this tool a late-bound attribute so we wouldn't incur overhead for this tool always. It doesn't seem like there's an API that currently allows us to do this.

There was also some discussion of if the attribute makes sense to be on every test rule or if it should be more global, maybe with a flag like --lcov_merger with this tool as the default.

I wanted to file this here so we could discuss this and unblock iOS tests supporting coverage.
@keith keith mentioned this issue Jan 23, 2020
Closed
@jin jin added team-Rules-Server Issues for serverside rules included with Bazel untriaged coverage labels Jan 27, 2020
@lberki lberki added P3 We're not considering working on this, but happy to review a PR. (No assignee) type: feature request and removed untriaged labels Nov 18, 2020
@ulfjack
Copy link
Contributor

ulfjack commented Jul 14, 2021

This looks like a dupe of #8736.

@keith keith mentioned this issue Sep 12, 2021
Closed
@fmeum fmeum mentioned this issue Nov 29, 2021
Closed
@fmeum fmeum mentioned this issue Feb 4, 2022
Closed
fmeum added a commit to fmeum/bazel that referenced this issue Mar 8, 2022
@fmeum
Expose CoverageOutputGenerator on a Fragment
0c3a4b6 
This allows Starlark rules to define _lcov_merger as a late-bound Starlark configuration_field in order not to pay the cost of building it when coverage isn't enabled.

Fixes bazelbuild#8736
Fixes bazelbuild#10642

Closes bazelbuild#14724.

RELNOTES: Add coverage configuration fragment, used to expose output_generator label.
PiperOrigin-RevId: 433156089
@fmeum fmeum mentioned this issue Mar 8, 2022
Merged
Wyverald pushed a commit that referenced this issue Mar 8, 2022
@fmeum
Expose CoverageOutputGenerator on a Fragment (#14997)
5e79972 
This allows Starlark rules to define _lcov_merger as a late-bound Starlark configuration_field in order not to pay the cost of building it when coverage isn't enabled.

Fixes #8736
Fixes #10642

Closes #14724.

RELNOTES: Add coverage configuration fragment, used to expose output_generator label.
PiperOrigin-RevId: 433156089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
coverage P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-Server Issues for serverside rules included with Bazel type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose CoverageOutputGenerator on a Fragment fmeum/bazel
4 participants
@keith @jin @lberki @ulfjack