Improve usefulness of NotASymlinkException#getMessage. Note that the …

…returned string can make its way into Bazel's printed error message. RELNOTES: None PiperOrigin-RevId: 240779338
bazelbuild · Mar 28, 2019 · d4f51b9 · d4f51b9
1 parent 18ef7a5
commit d4f51b9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/vfs/FileSystem.java b/src/main/java/com/google/devtools/build/lib/vfs/FileSystem.java
@@ -57,7 +57,7 @@ public DigestHashFunction getDigestFunction() {
    */
   protected static final class NotASymlinkException extends IOException {
     public NotASymlinkException(Path path) {
-      super(path.toString());
+      super(path + " is not a symlink");
     }
   }
 

diff --git a/src/test/java/com/google/devtools/build/lib/vfs/SymlinkAwareFileSystemTest.java b/src/test/java/com/google/devtools/build/lib/vfs/SymlinkAwareFileSystemTest.java
@@ -354,7 +354,7 @@ public void testReadSymbolicLink() throws IOException {
       xFile.readSymbolicLink(); // not a link
       fail();
     } catch (NotASymlinkException e) {
-      assertThat(e).hasMessageThat().isEqualTo(xFile.toString());
+      assertThat(e).hasMessageThat().isEqualTo(xFile.toString() + " is not a symlink");
     }
 
     try {