Run Buildifier on almost everything

PiperOrigin-RevId: 379365359

scripts/docs/BUILD

@@ -1,4 +1,4 @@
-load("//tools/python:private/defs.bzl", "py_library", "py_binary")
+load("//tools/python:private/defs.bzl", "py_binary", "py_library")
 
 filegroup(
     name = "srcs",

src/BUILD.tools

@@ -11,4 +11,3 @@ alias(
     actual = "//src/conditions:windows_msvc",
     visibility = ["//visibility:public"],
 )
-

src/main/java/com/google/devtools/build/lib/bazel/rules/android/android_ndk_misc_libraries_template.txt

@@ -1,6 +1,6 @@
 cc_library(
-    name = 'cpufeatures',
-    srcs = glob(['ndk/sources/android/cpufeatures/*.c']),
-    hdrs = glob(['ndk/sources/android/cpufeatures/*.h']),
-    linkopts = ['-ldl'],
+    name = "cpufeatures",
+    srcs = glob(["ndk/sources/android/cpufeatures/*.c"]),
+    hdrs = glob(["ndk/sources/android/cpufeatures/*.h"]),
+    linkopts = ["-ldl"],
 )

src/main/java/com/google/devtools/build/lib/bazel/rules/android/android_ndk_stl_filegroup_template.txt

@@ -2,4 +2,3 @@ filegroup(
     name = "%name%",
     srcs = glob(["%fileGlobPattern%"]),
 )
-

src/test/java/com/google/devtools/build/lib/blackbox/tests/manageddirs/BUILD.test

@@ -16,5 +16,5 @@ load(":test_rule.bzl", "test_rule")
 test_rule(
     name = "test_generated_deps",
     module_source = "@generated_node_modules//:example-module",
-    version = "0.2.0"
-)
+    version = "0.2.0",
+)

src/test/java/com/google/devtools/build/lib/blackbox/tests/manageddirs/WORKSPACE.test

@@ -11,8 +11,10 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-workspace(name = "fine_grained_user_modules",
-managed_directories = {'@generated_node_modules': ['node_modules']})
+workspace(
+    name = "fine_grained_user_modules",
+    managed_directories = {"@generated_node_modules": ["node_modules"]},
+)
 
 load(":use_node_modules.bzl", "generate_fine_grained_node_modules")
 

src/test/java/com/google/devtools/build/skydoc/testdata/attribute_defaults_test/input.bzl

@@ -52,6 +52,6 @@ my_rule = rule(
         "t": attr.string_list_dict(mandatory = True, doc = "Some string_list_dict"),
         "u": attr.string(),
         "v": attr.label(),
-        "w": attr.int()
+        "w": attr.int(),
     },
 )

src/test/py/bazel/testdata/runfiles_test/WORKSPACE.mock

@@ -3,11 +3,11 @@ workspace(name = "foo_ws")
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
 http_archive(
-  name = "rules_cc",
-  sha256 = "1d4dbbd1e1e9b57d40bb0ade51c9e882da7658d5bfbf22bbd15b68e7879d761f",
-  strip_prefix = "rules_cc-8bd6cd75d03c01bb82561a96d9c1f9f7157b13d0",
-  urls = [
-      "https://mirror.bazel.build/github.com/bazelbuild/rules_cc/archive/8bd6cd75d03c01bb82561a96d9c1f9f7157b13d0.zip",
-      "https://github.com/bazelbuild/rules_cc/archive/8bd6cd75d03c01bb82561a96d9c1f9f7157b13d0.zip",
-  ],
+    name = "rules_cc",
+    sha256 = "1d4dbbd1e1e9b57d40bb0ade51c9e882da7658d5bfbf22bbd15b68e7879d761f",
+    strip_prefix = "rules_cc-8bd6cd75d03c01bb82561a96d9c1f9f7157b13d0",
+    urls = [
+        "https://mirror.bazel.build/github.com/bazelbuild/rules_cc/archive/8bd6cd75d03c01bb82561a96d9c1f9f7157b13d0.zip",
+        "https://github.com/bazelbuild/rules_cc/archive/8bd6cd75d03c01bb82561a96d9c1f9f7157b13d0.zip",
+    ],
 )

src/test/py/bazel/testdata/runfiles_test/foo/BUILD.mock

@@ -3,10 +3,10 @@ py_binary(
     srcs = ["foo.py"],
     data = [
         "datadep/hello.txt",
+        "//bar:bar-cc",
         "//bar:bar-java",
         "//bar:bar-py",
         "//bar:bar-sh",
-        "//bar:bar-cc",
     ],
     main = "foo.py",
     deps = ["@bazel_tools//tools/python/runfiles"],
@@ -17,10 +17,10 @@ java_binary(
     srcs = ["Foo.java"],
     data = [
         "datadep/hello.txt",
-        "//bar:bar-py",
+        "//bar:bar-cc",
         "//bar:bar-java",
+        "//bar:bar-py",
         "//bar:bar-sh",
-        "//bar:bar-cc",
     ],
     main_class = "Foo",
     deps = ["@bazel_tools//tools/java/runfiles"],
@@ -31,27 +31,27 @@ sh_binary(
     srcs = ["foo.sh"],
     data = [
         "datadep/hello.txt",
+        "//bar:bar-cc",
         "//bar:bar-java",
         "//bar:bar-py",
         "//bar:bar-sh",
-        "//bar:bar-cc",
     ],
     deps = ["@bazel_tools//tools/bash/runfiles"],
 )
 
 cc_binary(
     name = "runfiles-cc",
     srcs = ["foo.cc"],
+    copts = select({
+        "@bazel_tools//src/conditions:windows": ["/DIS_WINDOWS=1"],
+        "//conditions:default": [],
+    }),
     data = [
         "datadep/hello.txt",
+        "//bar:bar-cc",
         "//bar:bar-java",
         "//bar:bar-py",
         "//bar:bar-sh",
-        "//bar:bar-cc",
     ],
-    copts = select({
-        "@bazel_tools//src/conditions:windows": ["/DIS_WINDOWS=1"],
-        "//conditions:default": [],
-    }),
     deps = ["@bazel_tools//tools/cpp/runfiles"],
 )

src/tools/android/java/com/google/devtools/build/android/desugar/scan/BUILD.tools

@@ -1,8 +1,8 @@
 java_binary(
     name = "KeepScanner",
     main_class = "com.google.devtools.build.android.desugar.scan.KeepScanner",
+    visibility = ["@bazel_tools//tools/android:__pkg__"],
     runtime_deps = [
         "//src/tools/android/java/com/google/devtools/build/android:all_android_tools",
     ],
-    visibility = ["@bazel_tools//tools/android:__pkg__"],
 )

tools/android/emulator/BUILD.tools

@@ -26,8 +26,8 @@ genrule(
     name = "empty_snapshot_fs",
     srcs = ["snapshots.img.zip"],
     outs = ["snapshots.img"],
-    tools = ["@bazel_tools//tools/zip:zipper"],
     cmd = "$(location @bazel_tools//tools/zip:zipper) x $< -d $(@D)",
+    tools = ["@bazel_tools//tools/zip:zipper"],
 )
 
 filegroup(

tools/android/runtime_deps/BUILD.bazel

@@ -40,10 +40,9 @@ genrule(
 )
 
 genrule(
-  name = "gen_version_txt",
-  outs = ["version.txt"],
-  stamp = True,
-  cmd = """
+    name = "gen_version_txt",
+    outs = ["version.txt"],
+    cmd = """
 embed_label="$$(grep BUILD_EMBED_LABEL bazel-out/stable-status.txt | cut -d ' ' -f 2-)"
 if [[ -z "$$embed_label" ]]; then
   # this happens when building for tests
@@ -65,6 +64,7 @@ bazel_repo_commit $$bazel_repo_commit
 built_with_bazel_version $$bazel_version
 EOF
 """,
+    stamp = True,
 )
 
 genrule(
@@ -77,10 +77,10 @@ genrule(
 pkg_tar(
     name = "android_tools",
     srcs = [
-        ":version.txt",
         "BUILD",
         "WORKSPACE",
         ":desugar_jdk_libs.jar",
+        ":version.txt",
         "//src/java_tools/import_deps_checker/java/com/google/devtools/build/importdeps:ImportDepsChecker_deploy.jar",
         "//src/tools/android/java/com/google/devtools/build/android:all_android_tools_deploy.jar",
     ],

tools/build_rules/BUILD.tools

@@ -2,4 +2,4 @@ filegroup(
     name = "bzl_srcs",
     srcs = glob(["*.bzl"]),
     visibility = ["//tools:__pkg__"],
-)
+)

tools/cpp/BUILD.static.bsd

@@ -15,7 +15,7 @@
 # This becomes the BUILD file for @local_config_cc// under FreeBSD and OpenBSD.
 
 load(":cc_toolchain_config.bzl", "cc_toolchain_config")
-load("@rules_cc//cc:defs.bzl", "cc_toolchain_suite", "cc_toolchain", "cc_library")
+load("@rules_cc//cc:defs.bzl", "cc_library", "cc_toolchain", "cc_toolchain_suite")
 
 package(default_visibility = ["//visibility:public"])
 

tools/def_parser/BUILD.tools

@@ -3,17 +3,17 @@ package(default_visibility = ["//visibility:public"])
 filegroup(
     name = "def_parser_windows",
     srcs = select({
-      "//src/conditions:remote": ["//third_party/def_parser:def_parser"],
-      "//conditions:default": ["def_parser.exe"],
+        "//src/conditions:remote": ["//third_party/def_parser:def_parser"],
+        "//conditions:default": ["def_parser.exe"],
     }),
 )
 
 filegroup(
     name = "def_parser",
     srcs = select({
-      "//src/conditions:host_windows": ["def_parser_windows"],
-      "//conditions:default": [
-        "no_op.bat",
-      ],
+        "//src/conditions:host_windows": ["def_parser_windows"],
+        "//conditions:default": [
+            "no_op.bat",
+        ],
     }),
 )

tools/distributions/debian/debian_cc.BUILD

@@ -31,14 +31,22 @@ cc_library(
 # libprotoc-dev
 cc_library(
     name = "protoc_lib",
-    linkopts = ["-lprotoc", "-lpthread", "-lm"],
-    deps = [":protobuf"],
+    linkopts = [
+        "-lprotoc",
+        "-lpthread",
+        "-lm",
+    ],
     visibility = ["//visibility:public"],
+    deps = [":protobuf"],
 )
 
 # libgrpc++-dev
 cc_library(
     name = "grpc++_unsecure",
-    linkopts = ["-lgrpc++_unsecure", "-lgrpc_unsecure", "-lgpr"],
+    linkopts = [
+        "-lgrpc++_unsecure",
+        "-lgrpc_unsecure",
+        "-lgpr",
+    ],
     visibility = ["//visibility:public"],
 )

tools/distributions/debian/debian_java.BUILD

@@ -231,6 +231,7 @@ filegroup(
 
 # libjacoco-java - BEGIN
 JACOCOVERSION = "0.8.6"
+
 java_import(
     name = "agent",
     jars = ["org.jacoco.agent.jar"],
@@ -320,9 +321,9 @@ java_import(
 filegroup(
     name = "auto_value-jars",
     srcs = [
+        "auto-common.jar",
         "auto-value.jar",
         "auto-value-annotations.jar",
-        "auto-common.jar",
         "escapevelocity.jar",
         "javapoet.jar",
     ],

tools/jdk/BUILD.java_tools_prebuilt

@@ -21,4 +21,4 @@ filegroup(
         ":windows": ["java_tools/ijar/ijar.exe"],
         "//conditions:default": ["java_tools/ijar/ijar"],
     }),
-)
+)

tools/jdk/jdk.BUILD

@@ -165,7 +165,10 @@ filegroup(
 #This folder holds security policies
 filegroup(
     name = "jdk-conf",
-    srcs = glob(["conf/**"], allow_empty = True),
+    srcs = glob(
+        ["conf/**"],
+        allow_empty = True,
+    ),
 )
 
 filegroup(

tools/launcher/BUILD.tools

@@ -3,17 +3,17 @@ package(default_visibility = ["//visibility:public"])
 filegroup(
     name = "launcher_windows",
     srcs = select({
-      "//src/conditions:remote": ["//src/tools/launcher:launcher"],
-      "//conditions:default": ["launcher.exe"],
+        "//src/conditions:remote": ["//src/tools/launcher:launcher"],
+        "//conditions:default": ["launcher.exe"],
     }),
 )
 
 filegroup(
     name = "launcher",
     srcs = select({
-      "//src/conditions:host_windows": [":launcher_windows"],
-      "//conditions:default": [
-        "//src/tools/launcher:launcher",
-      ],
+        "//src/conditions:host_windows": [":launcher_windows"],
+        "//conditions:default": [
+            "//src/tools/launcher:launcher",
+        ],
     }),
 )

tools/osx/crosstool/BUILD.toolchains

@@ -6,20 +6,62 @@ package(default_visibility = ["//visibility:public"])
 # TODO(apple-rules): Rename osx constraint to macOS.
 OSX_TOOLS_CONSTRAINTS = {
     "armeabi-v7a": ["@platforms//cpu:arm"],
-    "darwin_arm64": ["@platforms//os:osx", "@platforms//cpu:aarch64"],
-    "darwin_arm64e": ["@platforms//os:osx", "@platforms//cpu:aarch64"],
-    "darwin_x86_64": ["@platforms//os:osx", "@platforms//cpu:x86_64"],
-    "ios_arm64": ["@platforms//os:ios", "@platforms//cpu:aarch64"],
-    "ios_arm64e": ["@platforms//os:ios", "@platforms//cpu:aarch64"],
-    "ios_armv7": ["@platforms//os:ios", "@platforms//cpu:arm"],
-    "ios_i386": ["@platforms//os:ios", "@platforms//cpu:x86_32"],
-    "ios_x86_64": ["@platforms//os:ios", "@platforms//cpu:x86_64"],
-    "tvos_arm64": ["@platforms//os:ios", "@platforms//cpu:aarch64"],
-    "tvos_x86_64": ["@platforms//os:ios", "@platforms//cpu:x86_64"],
-    "watchos_arm64_32": ["@platforms//os:ios", "@platforms//cpu:aarch64"],
-    "watchos_armv7k": ["@platforms//os:ios", "@platforms//cpu:arm"],
-    "watchos_i386": ["@platforms//os:ios", "@platforms//cpu:x86_32"],
-    "watchos_x86_64": ["@platforms//os:ios", "@platforms//cpu:x86_64"],
+    "darwin_arm64": [
+        "@platforms//os:osx",
+        "@platforms//cpu:aarch64",
+    ],
+    "darwin_arm64e": [
+        "@platforms//os:osx",
+        "@platforms//cpu:aarch64",
+    ],
+    "darwin_x86_64": [
+        "@platforms//os:osx",
+        "@platforms//cpu:x86_64",
+    ],
+    "ios_arm64": [
+        "@platforms//os:ios",
+        "@platforms//cpu:aarch64",
+    ],
+    "ios_arm64e": [
+        "@platforms//os:ios",
+        "@platforms//cpu:aarch64",
+    ],
+    "ios_armv7": [
+        "@platforms//os:ios",
+        "@platforms//cpu:arm",
+    ],
+    "ios_i386": [
+        "@platforms//os:ios",
+        "@platforms//cpu:x86_32",
+    ],
+    "ios_x86_64": [
+        "@platforms//os:ios",
+        "@platforms//cpu:x86_64",
+    ],
+    "tvos_arm64": [
+        "@platforms//os:ios",
+        "@platforms//cpu:aarch64",
+    ],
+    "tvos_x86_64": [
+        "@platforms//os:ios",
+        "@platforms//cpu:x86_64",
+    ],
+    "watchos_arm64_32": [
+        "@platforms//os:ios",
+        "@platforms//cpu:aarch64",
+    ],
+    "watchos_armv7k": [
+        "@platforms//os:ios",
+        "@platforms//cpu:arm",
+    ],
+    "watchos_i386": [
+        "@platforms//os:ios",
+        "@platforms//cpu:x86_32",
+    ],
+    "watchos_x86_64": [
+        "@platforms//os:ios",
+        "@platforms//cpu:x86_64",
+    ],
 }
 
 OSX_DEVELOPER_PLATFORM_CPUS = [

tools/platforms/BUILD.tools

@@ -143,4 +143,3 @@ platform(
     ],
     target_platform = True,
 )
-