RELNOTES[INC]: Set stamping to false by default (i.e., --nostamp)

Stamping make build non-deterministic and should not be the default. -- MOS_MIGRATED_REVID=113040937
bazelbuild · Jan 26, 2016 · b88ef8f · b88ef8f
1 parent 96d3b96
commit b88ef8f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java
@@ -540,7 +540,7 @@ public String getCpu() {
     public List<Map.Entry<String, String>> pluginCoptList;
 
     @Option(name = "stamp",
-        defaultValue = "true",
+        defaultValue = "false",
         category = "semantics",
         help = "Stamp binaries with the date, username, hostname, workspace information, etc.")
     public boolean stampBinaries;

diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java
@@ -269,6 +269,8 @@ protected final BuildConfigurationCollection createConfigurations(String... args
           ruleClassProvider.getConfigurationOptions()));
     try {
       List<String> configurationArgs = new ArrayList<>();
+      // TODO(dmarting): Add --stamp option only to test that requires it.
+      configurationArgs.add("--stamp");  // Stamp is now defaulted to false.
       configurationArgs.add("--experimental_extended_sanity_checks");
       configurationArgs.addAll(getAnalysisMock().getOptionOverrides());