Skip to content

Commit

Permalink
Remove SkyframeExecutor#newPkgFunctionCache and `SkyframeExecutor#n…
Browse files Browse the repository at this point in the history
…ewCompiledBuildFileCache`.

We no longer have a need to customize these caches.

PiperOrigin-RevId: 406143404
  • Loading branch information
haxorz authored and copybara-github committed Oct 28, 2021
1 parent c952ba7 commit b4dfbca
Showing 1 changed file with 2 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -288,10 +288,10 @@ public abstract class SkyframeExecutor implements WalkableGraphFactory, Configur
// package twice (first time loading to find load()ed bzl files and declare Skyframe
// dependencies).
private final Cache<PackageIdentifier, LoadedPackageCacheEntry> packageFunctionCache =
newPkgFunctionCache();
Caffeine.newBuilder().build();
// Cache of parsed BUILD files, for PackageFunction. Same motivation as above.
private final Cache<PackageIdentifier, PackageFunction.CompiledBuildFile> compiledBuildFileCache =
newCompiledBuildFileCache();
Caffeine.newBuilder().build();

// Cache of parsed bzl files, for use when we're inlining BzlCompileFunction in
// BzlLoadFunction. See the comments in BzlLoadFunction for motivations and details.
Expand Down Expand Up @@ -1197,15 +1197,6 @@ public void injectExtraPrecomputedValues(List<PrecomputedValue.Injected> extraPr
}
}

protected Cache<PackageIdentifier, LoadedPackageCacheEntry> newPkgFunctionCache() {
return Caffeine.newBuilder().build();
}

protected Cache<PackageIdentifier, PackageFunction.CompiledBuildFile>
newCompiledBuildFileCache() {
return Caffeine.newBuilder().build();
}

private void setShowLoadingProgress(boolean showLoadingProgressValue) {
showLoadingProgress.set(showLoadingProgressValue);
}
Expand Down

0 comments on commit b4dfbca

Please sign in to comment.