Skip to content

Commit

Permalink
Rewrite TODOs to use internal bug id
Browse files Browse the repository at this point in the history
Issue #7010 has long been closed in OSS Bazel, but its Google-internal equivalent remains open, pending a cleanup of the depot.

RELNOTES: None
PiperOrigin-RevId: 305103124
  • Loading branch information
brandjon authored and copybara-github committed Apr 6, 2020
1 parent 0a89cef commit 97f9a93
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public RuleClass build(RuleClass.Builder builder, RuleDefinitionEnvironment env)
.mandatoryProvidersList(
ImmutableList.of(
// Legacy provider.
// TODO(#7010): Remove this legacy set.
// TODO(b/153363654): Remove this legacy set.
ImmutableList.of(
SkylarkProviderIdentifier.forLegacy(PyStructUtils.PROVIDER_NAME)),
// Modern provider.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
*
* <p>This class exposes a unified view over both the legacy and modern Python providers.
*/
// TODO(b/153363654): Delete this class, go directly through PyInfo instead.
public class PyProviderUtils {

// Disable construction.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
import com.google.devtools.build.lib.syntax.SkylarkType;

/** Static helper class for creating and accessing instances of the legacy "py" struct provider. */
// TODO(#7010): Remove this in favor of PyInfo.
// TODO(b/153363654): Remove this file.
public class PyStructUtils {

// Disable construction.
Expand Down

0 comments on commit 97f9a93

Please sign in to comment.