Skip to content

Commit

Permalink
Flip --incompatible_disable_nocopts
Browse files Browse the repository at this point in the history
Fixes #8546

RELNOTES: The --incompatible_disable_nocopts flag has been flipped. See #8546 for more information.
PiperOrigin-RevId: 264130705
  • Loading branch information
scentini authored and copybara-github committed Aug 19, 2019
1 parent 63409e8 commit 8b840e1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -892,7 +892,7 @@ public Label getFdoPrefetchHintsLabel() {

@Option(
name = "incompatible_disable_nocopts",
defaultValue = "false",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.ACTION_COMMAND_LINES},
metadataTags = {
Expand Down
6 changes: 4 additions & 2 deletions src/test/shell/integration/output_filter_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,13 @@ int main(void)
}
EOF

bazel build --output_filter="dummy" $pkg/cc/main:cc >&"$TEST_log" || fail "build failed"
bazel build --output_filter="dummy" --noincompatible_disable_nocopts \
$pkg/cc/main:cc >&"$TEST_log" || fail "build failed"
expect_not_log "triggers_a_warning"

echo "/* adding a comment forces recompilation */" >> $pkg/cc/main/main.c
bazel build $pkg/cc/main:cc >&"$TEST_log" || fail "build failed"
bazel build --noincompatible_disable_nocopts $pkg/cc/main:cc >&"$TEST_log" \
|| fail "build failed"
expect_log "triggers_a_warning"
}

Expand Down

0 comments on commit 8b840e1

Please sign in to comment.