Report a specific error when a Fileset is asked to traverse a source …

…directory.

PiperOrigin-RevId: 718831321
Change-Id: I6dc658fc1df481df4f04bd021f4df30c32939fe9

src/main/java/com/google/devtools/build/lib/skyframe/ArtifactFunction.java

@@ -338,6 +338,7 @@ private SkyValue createSourceValue(Artifact artifact, Environment env)
         case DANGLING_SYMLINK:
         case FILE_OPERATION_FAILURE:
         case SYMLINK_CYCLE_OR_INFINITE_EXPANSION:
+        case CANNOT_TRAVERSE_SOURCE_DIRECTORY:
           throw new ArtifactFunctionException(
               SourceArtifactException.create(artifact, e), Transience.PERSISTENT);
         case INCONSISTENT_FILESYSTEM:

src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryFunction.java

@@ -91,7 +91,7 @@ public SkyValue compute(SkyKey key, Environment env)
               String.format(
                   "%s contains a directory artifact '%s'",
                   params.getOwnerLabelForErrorMessages(), params.getDestPath()),
-              RecursiveFilesystemTraversalException.Type.FILE_OPERATION_FAILURE));
+              RecursiveFilesystemTraversalException.Type.CANNOT_TRAVERSE_SOURCE_DIRECTORY));
     }
 
     // The "direct" traversal params are present, which is the case when the FilesetEntry

src/main/java/com/google/devtools/build/lib/skyframe/RecursiveFilesystemTraversalFunction.java

@@ -112,6 +112,9 @@ public enum Type {
 
       /** The filesystem threw a {@link DetailedIOException}. */
       DETAILED_IO_EXCEPTION,
+
+      /** A traversal of a source directory was requested. */
+      CANNOT_TRAVERSE_SOURCE_DIRECTORY,
     }
 
     private final RecursiveFilesystemTraversalException.Type type;