Skip to content

Commit

Permalink
Flip --incompatible_objc_linking_info_migration to true
Browse files Browse the repository at this point in the history
See #16939.

This flips the default behavior so that builtin Objective C rules will get their
linking info from CcInfo instead of ObjcProvider.  We will start cleaning up
apple/swift starlark rules to stop generating linking info in ObjcProvider, so
it makes sense to flip the default for this flag before those changes land in
open source.

RELNOTES[inc]: builtin objc rules will get their linking info from CcInfo, not ObjcProvider

PiperOrigin-RevId: 504621116
Change-Id: I78ab2d3aca85dc0c7ef754dc8240ffa6a8f66ab9
  • Loading branch information
googlewalt authored and copybara-github committed Jan 25, 2023
1 parent c51d2bd commit 7b4acfe
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public class ObjcCommandLineOptions extends FragmentOptions {

@Option(
name = "incompatible_objc_linking_info_migration",
defaultValue = "false",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.TOOLCHAIN,
effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS, OptionEffectTag.CHANGES_INPUTS},
metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},
Expand Down

1 comment on commit 7b4acfe

@brentleyjones
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@googlewalt FYI, this currently broke open source rules_apple (we are behind on some commits for 7.0 support though): bazelbuild/rules_apple#1813

Please sign in to comment.