Skip to content

Commit

Permalink
Add TODO about trimming Starlark build configuration values.
Browse files Browse the repository at this point in the history
Progress on #6524.

PiperOrigin-RevId: 244960345
  • Loading branch information
mstaib authored and meisterT committed Apr 24, 2019
1 parent 9213f95 commit 090f051
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -901,6 +901,8 @@ private boolean isEmpty() {
*/
public static ConfigurationComparer.Result compareFragments(
OptionsDiffForReconstruction left, OptionsDiffForReconstruction right) {
// TODO: Add support for marking Starlark options as known default when trimming
// (sentinel object?)
Preconditions.checkArgument(
Arrays.equals(left.baseFingerprint, right.baseFingerprint),
"Can't compare diffs with different bases: %s and %s",
Expand Down

0 comments on commit 090f051

Please sign in to comment.