Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --incompatible_remap_main_repo for test #176

Closed
wants to merge 3 commits into from
Closed

Add --incompatible_remap_main_repo for test #176

wants to merge 3 commits into from

Conversation

meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy mentioned this pull request Jul 19, 2019
Closed
@meteorcloudy
Copy link
Member Author

@c-parsons Can you help merge this PR?

@c-parsons
Copy link
Collaborator

ugh, we have to resolve the buildifier issues or remove it as a presubmit request (or worse, manually push)

I'll try to find some time today to push the fixes to this PR

@thomasvl
Copy link
Member

#177 should clear things for the repo.

@aiuto
Copy link
Contributor

aiuto commented Aug 22, 2019

I think #184 will eliminate the need to run with this flag.

@aiuto
Copy link
Contributor

aiuto commented Aug 28, 2020

Is this obsolete?

@comius
Copy link
Collaborator

comius commented Jul 15, 2024

I believe this is obsolete.

@comius comius closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-parsons c-parsons c-parsons approved these changes

@laurentlb laurentlb Awaiting requested review from laurentlb

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@meteorcloudy @c-parsons @thomasvl @aiuto @comius @googlebot