Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support git_repository sources in BCR #3029

Merged

Conversation

armandomontanez
Copy link
Contributor

Adds workarounds in the BCR validation script to properly support git_repository sources as a step forwards toward bazelbuild/bazel#23461.

@armandomontanez armandomontanez marked this pull request as ready for review October 25, 2024 18:48
@Wyverald Wyverald requested a review from meteorcloudy October 29, 2024 21:19
@meteorcloudy
Copy link
Member

@fmeum @Wyverald Any concerns on supporting git_repository in BCR?

@fmeum
Copy link
Contributor

fmeum commented Oct 30, 2024

Not in general, but we have to be careful about what kind of refs we allow. Tags can be changed retroactively, so if we want the lockfiles to actually lock down the contents, we would need to restrict this to commits (living with the fact that the hash is just SHA-1).

@meteorcloudy
Copy link
Member

meteorcloudy commented Oct 30, 2024

That's a really good point! @armandomontanez Can you please add such a check? Basically, verify commit is specified and matches the commit hash pattern.

@armandomontanez
Copy link
Contributor Author

Good point, added a handful of checks/constraints to enforce this.

@meteorcloudy meteorcloudy merged commit 8dcbcf6 into bazelbuild:main Nov 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants