Skip to content

Commit

Permalink
Use more explicit visibilities.
Browse files Browse the repository at this point in the history
RELNOTES: None.
PiperOrigin-RevId: 229371245
  • Loading branch information
thomasvl authored and sergiocampama committed Jan 18, 2019
1 parent c090504 commit 80bb990
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 9 deletions.
6 changes: 4 additions & 2 deletions BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
package(default_visibility = ["//visibility:public"])

licenses(["notice"])

exports_files(["LICENSE"])
Expand All @@ -14,4 +12,8 @@ filegroup(
"@build_bazel_apple_support//rules:for_bazel_tests",
"@build_bazel_apple_support//tools:for_bazel_tests",
],
# Exposed publicly just so other rules can use this if they set up
# integration tests that need to copy all the support files into
# a temporary workspace for the tests.
visibility = ["//visibility:public"],
)
3 changes: 1 addition & 2 deletions lib/BUILD
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
licenses(["notice"])

package(default_visibility = ["//visibility:public"])

# Consumed by bazel tests.
filegroup(
name = "for_bazel_tests",
testonly = 1,
srcs = glob(["**"]),
visibility = ["//:__pkg__"],
)
3 changes: 1 addition & 2 deletions rules/BUILD
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
licenses(["notice"])

package(default_visibility = ["//visibility:public"])

# Consumed by bazel tests.
filegroup(
name = "for_bazel_tests",
testonly = 1,
srcs = glob(["**"]),
visibility = ["//:__pkg__"],
)
11 changes: 8 additions & 3 deletions tools/BUILD
Original file line number Diff line number Diff line change
@@ -1,19 +1,24 @@
licenses(["notice"])

package(default_visibility = ["//visibility:public"])

# Additional files, such as tools, that should be present in a test's runfiles
# during coverage collection.
filegroup(name = "coverage_support")
filegroup(
name = "coverage_support",
# Public so other rules can add the dependencies via this group.
visibility = ["//visibility:public"],
)

sh_binary(
name = "xcode_path_wrapper",
srcs = ["xcode_path_wrapper.sh"],
# Added to rules as a private attribute, so it needs to be public.
visibility = ["//visibility:public"],
)

# Consumed by bazel tests.
filegroup(
name = "for_bazel_tests",
testonly = 1,
srcs = glob(["**"]),
visibility = ["//:__pkg__"],
)

0 comments on commit 80bb990

Please sign in to comment.