Drop support for Bazel 6 #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luispadron feel free to kick off the workflow & review this PR whenever you're available 🙏 Let me know if I missed anything, I still see CI expecting 6.5.0 test so likely I am missing something |
luispadron
approved these changes
Dec 29, 2024
|
We'll have to update the required checks for the branch to remove Bazel 6. I can do that once this is ready to merge |
Perfect thank you! If it looks good to you, ready to merge |
|
Let's aim for sometime first week of January as most of reviewers are out right now and I'd like another approval |
luispadron
reviewed
Dec 30, 2024
luispadron
reviewed
Dec 30, 2024
jszumski
approved these changes
Jan 8, 2025
|
I updated the branch rules to remove the Bazel 6 status checks 👍 |
congt
approved these changes
Jan 9, 2025
|
thanks for taking care of this @ssarad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With new changes in rules_apple such as removal of legacy objc_provider, latest rules_apple and latest rules_ios are no longer compatible, the PR is up to fix but we need to drop support for Bazel 6 to move on with that PR due to rules_apple dropping support for Bazel 6
Additionally, @luispadron 's survey showed most of us are on Bazel 7.
Related PRs