Add objc_library binary to outputs of apple_framework_packaging rule when virtualized frameworks feature is enabled #931
+51
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where building an
apple_framework_packaging
rule with the VFS feature enabled wouldn't trigger objc compilation for the framework.When the VFS feature is disabled, the binaries from the
objc_library
andswift_library
targets are merged using libtool, and that binary is included in the outputs of theapple_framework_packaging
rule (see packaging action).When the VFS feature is enabled, all of the packaging actions are skipped, and the binaries from the
objc_library
andswift_library
targets aren't merged. One of the input binaries is arbitrarily included in the rule's output files -- for a target containing swift and objc sources, this would be theswift_library
binary.The PR adds both input binaries to the rule outputs when the VFS feature is enabled, so building an
apple_framework_packaging
rule triggers both objc and swift compilation actions.