Set xcode target build settings, so xcode indexer will work #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
reviewed
Jul 15, 2020
rules/xcodeproj.bzl
Outdated
| if fi[0] != '/': | ||
| fi = "$BAZEL_WORKSPACE_ROOT/%s" % fi | ||
| other_cflags.append("-F%s" % fi) | ||
| other_cflags.extend(["-D%s" % di for di in target[CcInfo].compilation_context.defines.to_list()]) |
There was a problem hiding this comment.
do we also want to pull out defines from the SwiftInfo provider to pass to to SWIFT_ACTIVE_COMPILATION_CONDITIONS ? What about paths to swiftmodules for non-framework deps (such as a test that will try to import its test host)?
segiddins
reviewed
Jul 17, 2020
segiddins
reviewed
Jul 21, 2020
rules/xcodeproj.bzl
Outdated
| "path": paths.join(src_dot_dots, s.short_path), | ||
| "group": paths.dirname(s.short_path), | ||
| "optional": True, | ||
| "compilerFlags": "-fobjc-no-arc", # TODO: why is this not working |
There was a problem hiding this comment.
probably because the flag is -fno-objc-arc
segiddins
approved these changes
Jul 22, 2020
… will succeed. If xcode indexer fails, autocomplete operations will not work.
972ff6f to
564db51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If xcode indexer fails, autocomplete operations will not work.