Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle bourne shell tokenization in objc_copts and linkopts when expanding xcconfigs #84

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

segiddins
Copy link
Member

obj_library and cc_library shell-expand their copts & linkopts, swift_library does not

segiddins added 2 commits July 2, 2020 11:00
…nding xcconfigs

obj_library and cc_library shell-expand their copts & linkopts, swift_library does not
@segiddins segiddins force-pushed the segiddins/copts-with-spaces branch from 52b25fe to 0bf63c5 Compare July 2, 2020 18:00
Copy link
Collaborator

@justinseanmartin justinseanmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@segiddins segiddins merged commit 236e6ec into master Jul 2, 2020
@segiddins segiddins deleted the segiddins/copts-with-spaces branch July 2, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants