Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lldb before build completion, point to workspace root #83

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

amberdixon
Copy link
Collaborator

Update lldbinit sourcemap before completing build, not in the background. Point to BAZEL_WORKSPACE_ROOT, not SRCROOT

…und. Point to BAZEL_WORKSPACE_ROOT, not SRCROOT
@amberdixon amberdixon requested review from ndizazzo and segiddins June 30, 2020 06:17
@@ -15,5 +15,5 @@ set -euo pipefail
#
# command source ~/.lldbinit-source-map
cat <<-END > ~/.lldbinit-source-map
settings set target.source-map ./ "$SRCROOT/"
settings set target.source-map ./ "$BAZEL_WORKSPACE_ROOT/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Copy link
Contributor

@ndizazzo ndizazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@amberdixon amberdixon merged commit e4ca0e5 into master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants