Add support for apple platform command line options #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20c1a20 to
cdb95fd
Compare
|
A step for bazel 7 migration #795 |
cdb95fd to
33055b5
Compare
jszumski
reviewed
Jan 4, 2024
luispadron
approved these changes
Feb 5, 2024
|
@karim-alweheshy I'll rebase and merge this once #835 lands. |
016fc08 to
11be6f5
Compare
luispadron
reviewed
Mar 1, 2024
luispadron
reviewed
Mar 1, 2024
luispadron
reviewed
Mar 1, 2024
b4c7f97 to
fbea2d5
Compare
f00c6f0 to
aff85fb
Compare
luispadron
reviewed
Mar 3, 2024
luispadron
reviewed
Mar 3, 2024
luispadron
reviewed
Mar 3, 2024
aff85fb to
58b67a1
Compare
41deaab to
2c90bd4
Compare
luispadron
approved these changes
Mar 4, 2024
| ) | ||
| for cpu, platform_name in CPU_TO_DEFAULT_PLATFORM_NAME.items() | ||
| } | ||
|
|
||
| def _current_apple_platform(apple_fragment, xcode_config): |
There was a problem hiding this comment.
This now matches rules_apple, thank you!
rules/transition_support.bzl
Outdated
| @@ -74,6 +102,19 @@ def _min_os_version_or_none(attr, attr_platforms, platform, attr_platform_type): | |||
|
|
|||
| return None | |||
|
|
|||
| def _objc_library_transition_values(settings, platform_type): | |||
There was a problem hiding this comment.
nit: im not sure the best name here but since this is related to the transition of apple platform moving to rules vs. defined in Bazel maybe something like this is more clear:
Suggested change
| def _objc_library_transition_values(settings, platform_type): | |
| def _apple_platforms_base_values(settings, platform_type): |
Alternatively we could try to match: https://github.com/bazelbuild/rules_apple/blob/master/apple/internal/transition_support.bzl#L440-L455
2c90bd4 to
bfdba6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Default bazel's transition of native.objc_library was removed in bazel 7. Resulting in the target to be built for the wrong platform. This PR adds the missing transition's command line flags to enable the correct target compilation+linking for the objc_library targets. The transition's code is only added if the host is running on bazel 7 +
Resources
Remove objc_library transition
Bazel changes
rules_apple changes 1
rules_apple changes 2
rules_apple changes 3