Generated xcodeproj improvements #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, github will collapse diffs & have more accurate repo stats
This way, everything will get chmod’d This fixes back-to-back runs of the installer failing due to permission issues
… in the project This would allow a project to, for example, include a README as a file reference, even though it isnt a src belonging to any particular target
So opening the project in Xcode doesn’t add a new file
ndizazzo
approved these changes
Jun 17, 2020
It avoids the warning of the presets not being found
db19402 to
8eee097
Compare
amberdixon
reviewed
Jun 17, 2020
| @@ -163,6 +176,7 @@ def _xcodeproj_impl(ctx): | |||
| "createIntermediateGroups": True, | |||
| "defaultConfig": "Debug", | |||
| "groupSortPosition": "none", | |||
| "settingPresets": "none", | |||
There was a problem hiding this comment.
fyi to reviewers, this is described here: https://github.com/yonaskolb/XcodeGen/blob/master/Docs/ProjectSpec.md#options
ob
approved these changes
Jun 17, 2020
| @@ -45,7 +45,11 @@ jobs: | |||
| - name: Select Xcode 11.2 | |||
| run: sudo xcode-select -s /Applications/Xcode_11.2.app | |||
| - name: Generate Xcode projects and compare against existing record | |||
| run: (bazelisk query 'kind(xcodeproj, tests/macos/xcodeproj/...)' | xargs -n 1 bazelisk run) && git diff --exit-code tests/macos/xcodeproj | |||
| run: | | |||
There was a problem hiding this comment.
Nice, more readable! Can we count on all the lines being run in the same shell? Otherwise the set -euo pipefail might not be taking effect...
There was a problem hiding this comment.
The whole run string gets executed at once by the shell
| set -euxo pipefail | ||
| rm -fr {package_name}/{target_name}.xcodeproj | ||
| bazel run {package_name}:{target_name} | ||
| bazel run {package_name}:{target_name} |
There was a problem hiding this comment.
yeah, it's testing re-generation (previously that was failing)
amberdixon
approved these changes
Jun 17, 2020
| @@ -0,0 +1 @@ | |||
| *.xcodeproj/ linguist-generated=true | |||
There was a problem hiding this comment.
Should we be seeing diffs for the pbxproj files in this PR?
Should this say /*.xcodeproj/ instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark xcodeproj directories as generated
This way, github will collapse diffs & have more accurate repo stats
Write all xcodeproj files into the tmp_dest
This way, everything will get chmod’d
This fixes back-to-back runs of the installer failing due to permission issues
Add a test that verifies that projects can regenerate without error
Add support for specifying additional (non-srcs) files to be included in the project
This would allow a project to, for example, include a README as a file reference, even though it isnt a src belonging to any particular target
Download GitHub repos via http_archive
Add IDEWorkspaceChecks.plist to generated projects
So opening the project in Xcode doesn’t add a new file
Include BUILD files in generated Xcode projects
Explicitly opt out of xcodeproj settings presets
It avoids the warning of the presets not being found