Adds deployment target configs based on provided platform_type & minimum_os_version #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@segiddins f6aec9a updates the min os version to 11 in an attempt to see if that corrects the build failures when the deployment target is set (and it's < iOS 11). Any idea what additional configs we might need to specify to get it working again with iOS 10? |
55ae1a2 to
5a5fe19
Compare
…mum_os_version * Adds VALID_ARCHs in combination with specifying the minimum deployment target corrects build issues
5a5fe19 to
1fe5dff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the suggested patch from @segiddins that allows platform and minimum deployment target to be passed through to target configuration option settings in Xcode.
If the platform is
iOS, it will addIPHONEOS_DEPLOYMENT_TARGETwith the corresponding minimum version.If the platform is
macOS, it will addMACOSX_DEPLOYMENT_TARGETwith the corresponding minimum version (and set theSDKROOTtomacosxif needed).