Revert "use swift_clang_module_aspect on apple_framework_packaging.transitive_deps (#3) (#570)" #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansitive_deps (bazel-ios#3) (bazel-ios#570)" This reverts commit 6f11291.
thiagohmcruz
approved these changes
May 9, 2023
|
FYI ran an internal build and a lot was broken for us because of this indeed, I'm glad we caught before others start trying to bump to latest |
luispadron
approved these changes
May 9, 2023
qyang-nj
added a commit
to qyang-nj/rules_ios
that referenced
this pull request
May 10, 2023
…aging.transitive_deps (#3) (bazel-ios#570)" (bazel-ios#715)" This reverts commit 5d32bd1.
qyang-nj
added a commit
to qyang-nj/rules_ios
that referenced
this pull request
May 10, 2023
…aging.transitive_deps (#3) (bazel-ios#570)" (bazel-ios#715)" This reverts commit 5d32bd1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6f11291 (#570). This fixes #712 and is confirmed in #713 (which can be merged after this is done since I don't have repo branch push access).