Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some further cleanup of the hmap rules #62

Merged
merged 2 commits into from
May 27, 2020
Merged

Some further cleanup of the hmap rules #62

merged 2 commits into from
May 27, 2020

Conversation

segiddins
Copy link
Member

  • Stop generating unused _frame_public_hmap.hmap files

@segiddins segiddins requested a review from ob May 19, 2020 03:46
ob
ob approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@ob ob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, like the new API

@segiddins segiddins changed the base branch from ob/hmap-v2 to master May 19, 2020 22:52
segiddins added 2 commits May 26, 2020 19:28
@segiddins
Stop generating (unused) _framework_public_hmap.hmap
b95b7df 
# Conflicts:
#	rules/framework.bzl
@segiddins
Add an API for generating hmaps
2a6b884 
# Conflicts:
#	rules/hmap.bzl
@segiddins segiddins force-pushed the segiddins/hmap-v2-cleanup branch from 479e0ef to 2a6b884 Compare May 27, 2020 02:30
@segiddins segiddins merged commit 0d483a6 into master May 27, 2020
@segiddins segiddins deleted the segiddins/hmap-v2-cleanup branch May 27, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob ob ob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@segiddins @ob