NFC: Cleanups #61
Merged
NFC: Cleanups #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41b5a15 to
a0eb75a
Compare
segiddins
reviewed
May 14, 2020
segiddins
approved these changes
May 14, 2020
|
conflicts due to my changes in previous PR. sorry :) |
Also enable starlark linting in CI
|
No worries, it wasn't hard to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardizes the C formatting using clang-format, and fixes a bunch of errors flagged by buildifier. It also removes some dead code. It is a non-functional change.
I was finishing #52 but kept mixing up formatting changes with the actual changes so I figured I'd do the cleanups first and then rebase #52 on top of this.