Fix swift's clang importer being able to see hmaps #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can only confuse clang, since all public headers are now visible via frameworks
objc_library already have the quotes stripped, and the extra quotes break swift_library from actually seeing the headermaps
gyfelton
approved these changes
Apr 23, 2020
Yes, and that's why we're removing it -- we want to specify headers explicitly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove public hmap propagation
It can only confuse clang, since all public headers are now visible via frameworks
Update shallow_since for rules_swift
Fix typo in hmap impl
Stop quoting the path to hmaps
objc_library already have the quotes stripped, and the extra quotes break swift_library from actually seeing the headermaps