Actually prepend copts so they get passed to tools #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a prior refactor, `_prepend_copts` didn't actually prepend to its parameters, but rather re-assigned. This PR ensures that the list that gets passed through to the underlying rules is modified. This change is tested by adding a library that cannot compile without the `copts` from its xcconfig applied. ObjC files using manual reference counting cannot be compiled without the `-fobjc-weak` flag, which in this case is only applied by the `CLANG_ENABLE_OBJC_WEAK` xcconfig.
5d1528b to
1fe8f45
Compare
| @@ -39,4 +39,12 @@ apple_framework( | |||
| }, | |||
| ) | |||
|
|
|||
| apple_framework( | |||
| name = "wont_build_without_xcconfig", | |||
| non_arc_srcs = ["weak_property.m"], | |||
There was a problem hiding this comment.
Do we know for sure that this option is working properly? Could potentially explicitly add a call to addRef and release so that compiling the code double checks that.
There was a problem hiding this comment.
We do, note that this target fails to compile without the xcconfig applied
justinseanmartin
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a prior refactor,
_prepend_coptsdidn't actually prepend toits parameters, but rather re-assigned.
This PR ensures that the list that gets passed through to the underlying
rules is modified.
This change is tested by adding a library that cannot compile without
the
coptsfrom its xcconfig applied. ObjC files using manual referencecounting cannot be compiled without the
-fobjc-weakflag, which inthis case is only applied by the
CLANG_ENABLE_OBJC_WEAKxcconfig.