Add resources to ios_unit_test kwargs #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- To see the bazel failure run: `bazel test //tests/test/ios:ResourcesAddedToUnitTestBundle` - This test fixture fails because we pass the `resources` keyword argument from the `rules_ios` `ios_unit_test` macro directly to the `swift_library` rule vended by `bazelbuild/rules_swift` as well as to Bazel's native `objc_library` rule. Neither of the signatures of these rule functions allow an argument named `resources`.
- Pass the `resources` argument from the `rules_ios` `ios_unit_test` macro into the `ios_unit_test` rule vended by `build_bazel/rules_apple` - Ensure the `resources` argument from the `rules_ios` `ios_unit_test` macro does not get passed along to `swift_library` and `objc_library` - To see the test pass run: `bazel test //tests/test/ios:ResourcesAddedToUnitTestBundle` - Closes: bazel-ios#35
segiddins
approved these changes
Apr 10, 2020
|
(Thanks for adding a test for this!!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the
resourcesargument from therules_iosios_unit_testmacro into theios_unit_testrule vended bybuild_bazel/rules_appleEnsure the
resourcesargument from therules_iosios_unit_testmacro does not get passed along toswift_libraryandobjc_library