Split out tests into multiple different github actions #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows sharing analysis cache between build/query
This should speed up PRs by parallelizing, as well as making it clearer which bit is failing
a18b0cc to
1a87bc5
Compare
Removing it makes the project diffable between machines
justinseanmartin
approved these changes
Mar 25, 2020
amberdixon
approved these changes
Mar 25, 2020
| runs-on: macOS-latest | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - name: Select Xcode 11.2 |
There was a problem hiding this comment.
small nit: is it necessary to select xcode versions before running buildifier?
| @@ -1,3 +1,3 @@ | |||
| # We can't create a bzl_library for rules-swift because of its visibility, | |||
| # so circumvent by not using the sandbox | |||
| build --strategy=Stardoc=standalone | |||
| common --strategy=Stardoc=standalone | |||
There was a problem hiding this comment.
I see the strategy option is documented in the bazel manuel and includes a valid value of standalone. But why is Stardoc also included here?
There was a problem hiding this comment.
because we only want to run actions with Stardoc as the mnemonic in standalone mode (we don't want to run other actions in standalone mode)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should speed up PRs by parallelizing, as well as making it clearer which bit is failing