Allow headers in test bundles /apps to be imported the same as in Xcode #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can have them not even be in the kwargs dict
This matches CocoaPods’ behavior - The namespace for header names is the Test/Framework name, rather than the module name - Test/Framework don’t use -import-underlying-modulemap, allowing bridging headers to be used
apple_common.Objc.direct_module_maps is broken coming from swift_library (it contains one level of transitive module maps), so ignore SwiftInfo from swift_library, since it doesn't have a module_map field anyway
justinseanmartin
previously approved these changes
Feb 14, 2020
justinseanmartin
approved these changes
Feb 18, 2020
|
@ob @chenxiao0228 btw this both adds a new test (:yay:) and uses |
ob
approved these changes
Feb 20, 2020
| @@ -15,6 +15,8 @@ PrivateHeaders = provider( | |||
| }, | |||
| ) | |||
|
|
|||
| _MANUAL = ["manual"] | |||
There was a problem hiding this comment.
nice, good idea tagging these as "manual"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, we can successfully run almost all of our apps & tests!
Add a test for a test target importing headers from its test host
Tag internally expanded rules as manual
Don’t try to gather direct_modulemaps from a swift target
apple_common.Objc.direct_module_maps is broken coming from swift_library
(it contains one level of transitive module maps), so ignore SwiftInfo from swift_library,
since it doesn't have a module_map field anyway
Stop generating modulemaps for tests & apps
This matches CocoaPods’ behavior
Specify custom swift_librart generated_header_name
Update to Bazel 2.1 and HEAD of apple rules
Infer LaunchScreen.storyboard from resources filegroup
Don’t default packaging rule attrs to none unecessarily
We can have them not even be in the kwargs dict