Skip to content

Commit

Permalink
Fix issue where a resource bundle's Info.plist value for CFBundleName…
Browse files Browse the repository at this point in the history
… incorrectly included the bundle extension (#728)
  • Loading branch information
jszumski authored Jun 2, 2023
1 parent 9d4ad96 commit cfcb0bf
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions rules/precompiled_apple_resource_bundle.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def _precompiled_apple_resource_bundle_impl(ctx):
control_files = []
input_files = []
output_files = []
output_bundle_dir = ctx.actions.declare_directory(paths.join(ctx.attr.name, bundle_name + ".bundle"))
output_bundle_dir = ctx.actions.declare_directory(paths.join(ctx.attr.name, bundle_name + ctx.attr.bundle_extension))

# Need getattr since the partial_ouput struct will be empty when there are no resources.
# Even so, we want to generate a resource bundle for compatibility.
Expand Down Expand Up @@ -252,7 +252,7 @@ _precompiled_apple_resource_bundle = rule(
),
bundle_extension = attr.string(
mandatory = False,
default = "bundle",
default = ".bundle",
doc = "The extension of the resource bundle.",
),
platforms = attr.string_dict(
Expand Down

0 comments on commit cfcb0bf

Please sign in to comment.