-
Notifications
You must be signed in to change notification settings - Fork 90
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[cache][multi-arch] use apple_common.multi_arch_split (#188)
* [cache][multi-arch] use apple_common.multi_arch_split This PR fixes #184 Today, there's redundant builds of a `swift_library` with `rules_ios` framework bundle and `rules_apple` bundles like a an app or test. Given: ``` apple_framework(name = "fw", ..) ios_application(name="app", deps=["fw"]) ``` When running the build, there will be 2 swiftmodules built ( 1 per the app, and 1 per the framework ) ``` bazel build -s tests/ios/app:App tests/ios/app:FW ``` Consequently, it builds 2x of all the transitive swift libraries and also causes issues with cache hits. The root cause is that multi platform support isn't implemented in rules apple. To partition up actions, we give the deps the transition `apple_common.multi_arch_split`. This implicates a different configuration Note that there is more changes to handle `ios_multi_cpus` end to end #186
- Loading branch information
1 parent
6556739
commit 1b32a5c
Showing
6 changed files
with
49 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.